diff --git a/lib/gitlab/email/handler.rb b/lib/gitlab/email/handler.rb index 55fbee276b851b59eb9fd496bf13f92b1a399e1e..56d848cdd7b0a2c332d9eb8177a3fabf1e11916c 100644 --- a/lib/gitlab/email/handler.rb +++ b/lib/gitlab/email/handler.rb @@ -25,7 +25,7 @@ module Gitlab def validate_permission!(permission) raise UserNotFoundError unless author raise UserBlockedError if author.blocked? - # TODO: Give project not found error if author cannot read project + raise ProjectNotFound unless author.can?(:read_project, project) raise UserNotAuthorizedError unless author.can?(permission, project) end diff --git a/lib/gitlab/email/handler/create_issue.rb b/lib/gitlab/email/handler/create_issue.rb index 24f8f59900d12febdbaa89ffb064126f0450c1cb..8829fbb0e4958a8517288ed96a5840c6d5039b90 100644 --- a/lib/gitlab/email/handler/create_issue.rb +++ b/lib/gitlab/email/handler/create_issue.rb @@ -10,9 +10,6 @@ module Gitlab end def execute - # Must be private project without access - raise ProjectNotFound unless author.can?(:read_project, project) - validate_permission!(:create_issue) validate_authentication_token! diff --git a/spec/lib/gitlab/email/receiver_spec.rb b/spec/lib/gitlab/email/receiver_spec.rb index 58c525f4048e92c4e40eb4549032aec089397fd0..a9b93044a08e20a833d8fe0dbc153b9b8767db91 100644 --- a/spec/lib/gitlab/email/receiver_spec.rb +++ b/spec/lib/gitlab/email/receiver_spec.rb @@ -88,8 +88,8 @@ describe Gitlab::Email::Receiver, lib: true do project.update_attribute(:visibility_level, Project::PRIVATE) end - it "raises a UserNotAuthorizedError" do - expect { receiver.execute }.to raise_error(Gitlab::Email::UserNotAuthorizedError) + it "raises a ProjectNotFound" do + expect { receiver.execute }.to raise_error(Gitlab::Email::ProjectNotFound) end end