From ef833a220508f6f8a692b74e7fe593c68981d6f5 Mon Sep 17 00:00:00 2001
From: Lin Jen-Shin <godfat@godfat.org>
Date: Mon, 11 Jul 2016 18:51:23 +0800
Subject: [PATCH] Give latest succeeded one, don't give pending/running ones

---
 app/controllers/projects/artifacts_controller.rb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/app/controllers/projects/artifacts_controller.rb b/app/controllers/projects/artifacts_controller.rb
index c00295cd3b5..f71499be4f7 100644
--- a/app/controllers/projects/artifacts_controller.rb
+++ b/app/controllers/projects/artifacts_controller.rb
@@ -61,7 +61,9 @@ class Projects::ArtifactsController < Projects::ApplicationController
 
   def build_from_ref
     if params[:ref]
-      project.builds_for(params[:build_name], params[:ref]).latest.first
+      builds = project.builds_for(params[:build_name], params[:ref])
+
+      builds.latest.success.first
     end
   end
 
-- 
GitLab