From fab8bc5313a56c5f22e56903de2cb9c86df79fe4 Mon Sep 17 00:00:00 2001
From: Lin Jen-Shin <godfat@godfat.org>
Date: Thu, 14 Jul 2016 14:26:04 +0800
Subject: [PATCH] More descriptive local variable, feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_13047190
---
app/models/project.rb | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/app/models/project.rb b/app/models/project.rb
index 48bb9743439..793cf2d70fb 100644
--- a/app/models/project.rb
+++ b/app/models/project.rb
@@ -430,13 +430,13 @@ class Project < ActiveRecord::Base
end
def builds_for(build_name, ref = 'HEAD')
- ct = commit(ref)
+ commit_object = commit(ref)
- if ct.nil?
+ if commit_object.nil?
builds.none
else
builds.joins(:pipeline).
- merge(Ci::Pipeline.where(sha: ct.sha)).
+ merge(Ci::Pipeline.where(sha: commit_object.sha)).
where(name: build_name)
end
end
--
GitLab