Skip to content
Snippets Groups Projects
  1. May 19, 2017
  2. May 18, 2017
  3. May 15, 2017
  4. May 12, 2017
  5. May 10, 2017
  6. May 08, 2017
    • Toon Claes's avatar
      Devise can assign trackable fields, but only allow writes once/hour · 3531ea09
      Toon Claes authored
      Not assigning the trackable fields seems to cause strange side-effects.
      3531ea09
    • Toon Claes's avatar
      Limit `update_tracked_fields` to write to database once/hour · 6a915d6f
      Toon Claes authored
      Every time a user logs in or out, the Trackable attributes are written to the
      database. This is causing a lot of load on the database, for data that isn't
      really critical.
      
      So to avoid the database being hammered, add a Gitlab::ExclusiveLease before
      writing trackable attributes to the database. This lease expires after an hour,
      so only when the attributes were written more than an hour ago, they can be
      written again. Otherwise they are ignored.
      6a915d6f
    • Stan Hu's avatar
      Fix sub-second timing comparison error for Devise confirmation period · c175c30d
      Stan Hu authored
      On databases such as MySQL, it's possible to get into a timing comparison
      error if the value of `Confirmable#confirmation_sent_at` is within a second
      of `0.days.ago`. This is possible mostly in specs that test this behavior
      and most likely not happening in practice. The result of this error causes
      a user to be deemed active when it should be inactive. To prevent this
      error, we explicitly check the configuration setting to be `0.days.ago`.
      
      Closes gitlab-org/gitlab-ee#2362
      c175c30d
  7. May 05, 2017
  8. May 04, 2017
  9. May 03, 2017
  10. May 01, 2017
  11. Apr 26, 2017
  12. Apr 20, 2017
  13. Apr 19, 2017
  14. Apr 18, 2017
  15. Apr 14, 2017
  16. Apr 11, 2017
  17. Apr 10, 2017
  18. Apr 09, 2017
  19. Apr 06, 2017
    • Timothy Andrew's avatar
      Implement review comments from @DouweM for !10467. · 1c42505b
      Timothy Andrew authored
      1. Have `MigrateToGhostUser` be a service rather than a mixed-in module, to keep
         things explicit. Specs testing the behavior of this class are moved into a
         separate service spec file.
      
      2. Add a `user.reported_abuse_reports` association to make the
         `migrate_abuse_reports` method more consistent with the other `migrate_`
         methods.
      Unverified
      1c42505b
    • Timothy Andrew's avatar
      Fix a bug with the User#abuse_report association. · 6a065074
      Timothy Andrew authored
      Introduction
      ------------
      
      1. The foreign key was not explicitly specified on the association.
      2. The `AbuseReport` model contains two references to user - `reporter_id` and
         `user_id`
      3. `user.abuse_report` is supposed to return the single abuse report where
         `user_id` refers to the given user.
      
      Bug Description
      ---------------
      
      1. `user.abuse_report` would return an abuse report where `reporter_id` referred
         to the current user, if such an abuse report was present.
      
      2. This implies a slightly more serious bug as well:
      
         - Assume User A filed an abuse report against User B
         - We have an abuse report where `reporter_id` is User A and `user_id` is User B
         - If User A is updated (`user_a.block`, for example), the abuse report would
           also be updated, such that both `reporter_id` _and_ `user_id` point to User A.
      
      Fix
      ---
      
      Explicitly declare the foreign key `user_id` in the `has_one` declaration
      Unverified
      6a065074
    • Alexis Reigel's avatar
      01be21d4
    • Alexis Reigel's avatar
      1735ed61
    • Alexis Reigel's avatar
      check all groups for 2fa requirement · 20575859
      Alexis Reigel authored
      20575859
    • Markus Koller's avatar
      Support 2FA requirement per-group · a3430f01
      Markus Koller authored
      a3430f01
  20. Mar 30, 2017
  21. Mar 27, 2017
  22. Mar 24, 2017
  23. Mar 22, 2017
Loading