Skip to content
Snippets Groups Projects

Custom issue trackers don't substitute issues_tracker_id

Problem

In former versions of GitLab the admin could configure a custom issue tracker (e.g. Redmine) and the URLs would be build by using the configuration + substituting :issues_tracker_id and :id.

Current master (7561b1c2) doesn't support this feature in two ways:

  1. The project's issues_tracker_id cannot be set using the UI anymore (The option for setting the project's issues_tracker_id was removed in a720dde6)
  2. Even if set (e.g. by using the console) the :issues_tracker_id placeholder isn't substituted correctly

I'm opening only one issue for this matter as fixing only one of both problems doesn't seems to make any sense for me.

Steps to reproduce 1

  1. Install a vanilla gitlab-development-kit installation and start all instances
  2. Check that the input field to configure the issues_tracker_id is gone one the project's settings page:
  3. Visit: http://localhost:3000/documentcloud/underscore/edit

Steps to reproduce 2

  1. Install a vanilla gitlab-development-kit installation and start all instances
  2. Enable a custom issue tracker. Example for project DocumentCloud/Underscore:
  3. Visit: http://localhost:3000/documentcloud/underscore/services/redmine/edit
  4. Configure the urls (s. screenshot) and save: Underscore | GitLab 2015-02-24 12-12-19
  5. Manually set a project's issues_tracker_id
  6. Start a new console: rails c
  7. Manually update the tracker's id: Project.find(1).update_attributes!(:issues_tracker_id => "custom_tracker_id") (This updates the documentcloud/underscore project)
  8. Note the custom issues tracker URLs are used but the placeholders not substituted
  9. Visit: http://localhost:3000/documentcloud/underscore
  10. The URL linked for "Issues" in the sidebar is http://localhost/redmine/:issues_tracker_id/
  11. Also for single issue links only the :id placeholder is substituted:
  12. Visit: http://localhost:3000/documentcloud/underscore/commit/044ba5c3502dfac26c1a863a62c518b91e2a255d
  13. Add a new comment: This is a dummy reference #1
  14. The URL linked to the single reference is: http://localhost/redmine/:issues_tracker_id/issues/1

My two cents

I think 1) can easily be fixed by re-adding the configuration option to the settings page. See my commit for a hint https://gitlab.com/jnbt/gitlab-ce/commit/0c4a136683948d534ffd8971680c65a13a489f3e. I can make a MR if wished, but I'm unsure how to write a test case for this.

I didn't got 2) fixed as I don't fully understand the concept the services and their config. It seems that the class Service and IssueTrackerService should already support the usage of the placeholders, but the code path isn't executed at all. My guess this bases on accessing Gitlab.config.issues_tracker in https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/models/project_services/issue_tracker_service.rb#L93