Branded login page for CE
Report https://news.ycombinator.com/item?id=10931347
Merge http://doc.gitlab.com/ee/customization/branded_login_page.html from EE into CE.
I think it makes sense for smaller organizations to need this.
When you are in the app it is branded by the GitLab icon and logo already (that also serves as loading indicator).
On the login page you have 'About GitLab' in the footer anyway.
@dzaporozhets are you OK with this? /cc @JobV @AshleyS
Activity
@sytses I think it makes sense. It will also simplify us frontend development
@dzaporozhets thanks!
@ChadMalchow are you OK with this too?
@sytses thank you for asking. I am okay with this as this feature is not one that is requested as a reason organizations choose EE.
@ChadMalchow thanks!
We're doing this.
Added promised label
When you are in the app it is branded by the GitLab icon and logo already (that also serves as loading indicator).
@sytses The GitLab (loading indicator) logo at the top of the sidebar can also be customized with this feature (as well as the title and description in the sign-in/up pages), so I guess it's not that simple?
cc @DouweM
@zj Can you have a look here?
@DouweM Ill take a look at it in the coming week!
Reassigned to @zj
@dzaporozhets @DouweM would it be reasonable to ship this in a patch, as people were waiting for it?
Edited by 🚄 Job van der Voort 🚀-
@DouweM I just started this, and hope to continue and finish this tonight. Depending on the review in my mind this should be ready in the next day or two.
mentioned in merge request !2927 (merged)
mentioned in issue #13239 (moved)
Milestone changed to 8.6
Status changed to closed by merge request !2927 (merged)
mentioned in commit 2ea8f71b
mentioned in commit 5a3c5ace
mentioned in issue #14201 (closed)
Mentioned in commit maxraab/gitlab-ce@5a3c5ace
