Skip to content
Snippets Groups Projects
New issue look: Off

migrating from gitorious doesn't make fully functional project pages

    • Closed Issue created by username-removed-105950 @nmav

    I've attempted to migrate gnutls from gitorious to gitlab. Most of the pages seem to work: https://gitlab.com/gnutls/gnutls

    However, https://gitlab.com/gnutls/gnutls/commits/master and https://gitlab.com/gnutls/gnutls/branches do return 500 error.

    Designs

      Child items ...

      2. Activity

      • username-removed-2900
        username-removed-2900 @razer6 ·
        Maintainer

        /cc @sytses @dzaporozhets @marin Maybe you can investigate what's going on on gitlab.com

      • Marin Jankovski
        Marin Jankovski @marin ·
        Maintainer

        @valery Can you take a look?

      • Douwe Maan
        Douwe Maan @DouweM ·
        Maintainer

        I've reproduced it locally, the stack trace is below.

        The error originates here: https://gitlab.com/gitlab-org/gitlab_git/blob/master/lib/gitlab_git/repository.rb#L72

        The problem is an annotated tag gnutls-0-0-7 with a nil message, which gitlab_git isn't prepared for.

        NoMethodError - undefined method `chomp' for nil:NilClass:
  gitlab_git (7.0.0.rc14) lib/gitlab_git/repository.rb:72:in `block in tags'
  gitlab_git (7.0.0.rc14) lib/gitlab_git/repository.rb:67:in `tags'
  app/models/repository.rb:169:in `method_missing'
  app/views/projects/commits/_head.html.haml:15:in `block (2 levels) in _app_views_projects_commits__head_html_haml___2983411259939717915_70174313381720'
  haml (4.0.5) lib/haml/helpers.rb:368:in `block in capture_haml'
  haml (4.0.5) lib/haml/helpers.rb:608:in `with_haml_buffer'
  haml (4.0.5) lib/haml/helpers.rb:364:in `capture_haml'
  haml (4.0.5) lib/haml/helpers/xss_mods.rb:61:in `capture_haml_with_haml_xss'
  haml (4.0.5) lib/haml/helpers/action_view_mods.rb:45:in `capture_with_haml'
  actionview (4.1.9) lib/action_view/helpers/tag_helper.rb:97:in `content_tag'
  haml (4.0.5) lib/haml/helpers/action_view_mods.rb:69:in `content_tag_with_haml'
  actionview (4.1.9) lib/action_view/helpers/url_helper.rb:184:in `link_to'
  app/helpers/application_helper.rb:278:in `link_to'
  app/views/projects/commits/_head.html.haml:13:in `block in _app_views_projects_commits__head_html_haml___2983411259939717915_70174313381720'
  haml (4.0.5) lib/haml/helpers.rb:368:in `block in capture_haml'
  haml (4.0.5) lib/haml/helpers.rb:608:in `with_haml_buffer'
  haml (4.0.5) lib/haml/helpers.rb:364:in `capture_haml'
  haml (4.0.5) lib/haml/helpers/xss_mods.rb:61:in `capture_haml_with_haml_xss'
  haml (4.0.5) lib/haml/helpers/action_view_mods.rb:45:in `capture_with_haml'
  app/helpers/tab_helper.rb:55:in `nav_link'
  app/views/projects/commits/_head.html.haml:12:in `_app_views_projects_commits__head_html_haml___2983411259939717915_70174313381720'
  actionview (4.1.9) lib/action_view/template.rb:145:in `block in render'
  activesupport (4.1.9) lib/active_support/notifications.rb:161:in `instrument'
  actionview (4.1.9) lib/action_view/template.rb:339:in `instrument'
  actionview (4.1.9) lib/action_view/template.rb:143:in `render'
  rack-mini-profiler (0.9.0) lib/mini_profiler/profiling_methods.rb:108:in `block in profile_method'
  actionview (4.1.9) lib/action_view/renderer/partial_renderer.rb:306:in `render_partial'
  actionview (4.1.9) lib/action_view/renderer/partial_renderer.rb:279:in `block in render'
  actionview (4.1.9) lib/action_view/renderer/abstract_renderer.rb:38:in `block in instrument'
  activesupport (4.1.9) lib/active_support/notifications.rb:159:in `block in instrument'
  activesupport (4.1.9) lib/active_support/notifications/instrumenter.rb:20:in `instrument'
  activesupport (4.1.9) lib/active_support/notifications.rb:159:in `instrument'
  actionview (4.1.9) lib/action_view/renderer/abstract_renderer.rb:38:in `instrument'
  actionview (4.1.9) lib/action_view/renderer/partial_renderer.rb:278:in `render'
  actionview (4.1.9) lib/action_view/renderer/renderer.rb:47:in `render_partial'
  actionview (4.1.9) lib/action_view/helpers/rendering_helper.rb:35:in `render'
  haml (4.0.5) lib/haml/helpers/action_view_mods.rb:10:in `block in render_with_haml'
  haml (4.0.5) lib/haml/helpers.rb:89:in `non_haml'
  haml (4.0.5) lib/haml/helpers/action_view_mods.rb:10:in `render_with_haml'
  app/views/projects/commits/show.html.haml:1:in `_app_views_projects_commits_show_html_haml___3982401130102178538_70174278426640'
  actionview (4.1.9) lib/action_view/template.rb:145:in `block in render'
  activesupport (4.1.9) lib/active_support/notifications.rb:161:in `instrument'
  actionview (4.1.9) lib/action_view/template.rb:339:in `instrument'
  actionview (4.1.9) lib/action_view/template.rb:143:in `render'
  rack-mini-profiler (0.9.0) lib/mini_profiler/profiling_methods.rb:108:in `block in profile_method'
  actionview (4.1.9) lib/action_view/renderer/template_renderer.rb:55:in `block (2 levels) in render_template'
  actionview (4.1.9) lib/action_view/renderer/abstract_renderer.rb:38:in `block in instrument'
  activesupport (4.1.9) lib/active_support/notifications.rb:159:in `block in instrument'
  activesupport (4.1.9) lib/active_support/notifications/instrumenter.rb:20:in `instrument'
  activesupport (4.1.9) lib/active_support/notifications.rb:159:in `instrument'
  actionview (4.1.9) lib/action_view/renderer/abstract_renderer.rb:38:in `instrument'
  actionview (4.1.9) lib/action_view/renderer/template_renderer.rb:54:in `block in render_template'
  actionview (4.1.9) lib/action_view/renderer/template_renderer.rb:62:in `render_with_layout'
  actionview (4.1.9) lib/action_view/renderer/template_renderer.rb:53:in `render_template'
  actionview (4.1.9) lib/action_view/renderer/template_renderer.rb:17:in `render'
  actionview (4.1.9) lib/action_view/renderer/renderer.rb:42:in `render_template'
  actionview (4.1.9) lib/action_view/renderer/renderer.rb:23:in `render'
  actionview (4.1.9) lib/action_view/rendering.rb:99:in `_render_template'
  actionpack (4.1.9) lib/action_controller/metal/streaming.rb:217:in `_render_template'
  actionview (4.1.9) lib/action_view/rendering.rb:82:in `render_to_body'
  actionpack (4.1.9) lib/action_controller/metal/rendering.rb:32:in `render_to_body'
  actionpack (4.1.9) lib/action_controller/metal/renderers.rb:32:in `render_to_body'
  actionpack (4.1.9) lib/abstract_controller/rendering.rb:25:in `render'
  actionpack (4.1.9) lib/action_controller/metal/rendering.rb:16:in `render'
  actionpack (4.1.9) lib/action_controller/metal/instrumentation.rb:41:in `block (2 levels) in render'
  activesupport (4.1.9) lib/active_support/core_ext/benchmark.rb:12:in `block in ms'
  /Users/douwemaan/.rvm/rubies/ruby-2.1.5/lib/ruby/2.1.0/benchmark.rb:294:in `realtime'
  activesupport (4.1.9) lib/active_support/core_ext/benchmark.rb:12:in `ms'
  actionpack (4.1.9) lib/action_controller/metal/instrumentation.rb:41:in `block in render'
  actionpack (4.1.9) lib/action_controller/metal/instrumentation.rb:84:in `cleanup_view_runtime'
  activerecord (4.1.9) lib/active_record/railties/controller_runtime.rb:25:in `cleanup_view_runtime'
  actionpack (4.1.9) lib/action_controller/metal/instrumentation.rb:40:in `render'
  actionpack (4.1.9) lib/action_controller/metal/mime_responds.rb:258:in `respond_to'
  app/controllers/projects/commits_controller.rb:18:in `show'
  actionpack (4.1.9) lib/action_controller/metal/implicit_render.rb:4:in `send_action'
  actionpack (4.1.9) lib/abstract_controller/base.rb:189:in `process_action'
  actionpack (4.1.9) lib/action_controller/metal/rendering.rb:10:in `process_action'
  actionpack (4.1.9) lib/abstract_controller/callbacks.rb:20:in `block in process_action'
  activesupport (4.1.9) lib/active_support/callbacks.rb:113:in `call'
  activesupport (4.1.9) lib/active_support/callbacks.rb:166:in `block in halting'
  activesupport (4.1.9) lib/active_support/callbacks.rb:166:in `block in halting'
  activesupport (4.1.9) lib/active_support/callbacks.rb:166:in `block in halting'
  activesupport (4.1.9) lib/active_support/callbacks.rb:166:in `block in halting'
  activesupport (4.1.9) lib/active_support/callbacks.rb:166:in `block in halting'
  activesupport (4.1.9) lib/active_support/callbacks.rb:229:in `block in halting'
  activesupport (4.1.9) lib/active_support/callbacks.rb:166:in `block in halting'
  activesupport (4.1.9) lib/active_support/callbacks.rb:166:in `block in halting'
  activesupport (4.1.9) lib/active_support/callbacks.rb:229:in `block in halting'
  activesupport (4.1.9) lib/active_support/callbacks.rb:149:in `block in halting_and_conditional'
  activesupport (4.1.9) lib/active_support/callbacks.rb:149:in `block in halting_and_conditional'
  activesupport (4.1.9) lib/active_support/callbacks.rb:166:in `block in halting'
  activesupport (4.1.9) lib/active_support/callbacks.rb:166:in `block in halting'
  activesupport (4.1.9) lib/active_support/callbacks.rb:166:in `block in halting'
  activesupport (4.1.9) lib/active_support/callbacks.rb:166:in `block in halting'
  activesupport (4.1.9) lib/active_support/callbacks.rb:166:in `block in halting'
  activesupport (4.1.9) lib/active_support/callbacks.rb:166:in `block in halting'
  activesupport (4.1.9) lib/active_support/callbacks.rb:166:in `block in halting'
  activesupport (4.1.9) lib/active_support/callbacks.rb:166:in `block in halting'
  activesupport (4.1.9) lib/active_support/callbacks.rb:86:in `run_callbacks'
  actionpack (4.1.9) lib/abstract_controller/callbacks.rb:19:in `process_action'
  actionpack (4.1.9) lib/action_controller/metal/rescue.rb:29:in `process_action'
  actionpack (4.1.9) lib/action_controller/metal/instrumentation.rb:31:in `block in process_action'
  activesupport (4.1.9) lib/active_support/notifications.rb:159:in `block in instrument'
  activesupport (4.1.9) lib/active_support/notifications/instrumenter.rb:20:in `instrument'
  activesupport (4.1.9) lib/active_support/notifications.rb:159:in `instrument'
  actionpack (4.1.9) lib/action_controller/metal/instrumentation.rb:30:in `process_action'
  actionpack (4.1.9) lib/action_controller/metal/params_wrapper.rb:250:in `process_action'
  activerecord (4.1.9) lib/active_record/railties/controller_runtime.rb:18:in `process_action'
  actionpack (4.1.9) lib/abstract_controller/base.rb:136:in `process'
  actionview (4.1.9) lib/action_view/rendering.rb:30:in `process'
  rack-mini-profiler (0.9.0) lib/mini_profiler/profiling_methods.rb:108:in `block in profile_method'
  actionpack (4.1.9) lib/action_controller/metal.rb:196:in `dispatch'
  actionpack (4.1.9) lib/action_controller/metal/rack_delegation.rb:13:in `dispatch'
  actionpack (4.1.9) lib/action_controller/metal.rb:232:in `block in action'
  actionpack (4.1.9) lib/action_dispatch/routing/route_set.rb:82:in `dispatch'
  actionpack (4.1.9) lib/action_dispatch/routing/route_set.rb:50:in `call'
  actionpack (4.1.9) lib/action_dispatch/journey/router.rb:73:in `block in call'
  actionpack (4.1.9) lib/action_dispatch/journey/router.rb:59:in `call'
  actionpack (4.1.9) lib/action_dispatch/routing/route_set.rb:685:in `call'
  omniauth (1.1.4) lib/omniauth/strategy.rb:184:in `call!'
  omniauth (1.1.4) lib/omniauth/strategy.rb:164:in `call'
  omniauth (1.1.4) lib/omniauth/strategy.rb:184:in `call!'
  omniauth (1.1.4) lib/omniauth/strategy.rb:164:in `call'
  request_store (1.0.5) lib/request_store/middleware.rb:9:in `call'
  rack-cors (0.2.9) lib/rack/cors.rb:54:in `call'
  rack-attack (4.2.0) lib/rack/attack.rb:104:in `call'
  warden (1.2.3) lib/warden/manager.rb:35:in `block in call'
  warden (1.2.3) lib/warden/manager.rb:34:in `call'
  rack (1.5.2) lib/rack/etag.rb:23:in `call'
  rack (1.5.2) lib/rack/conditionalget.rb:25:in `call'
  rack (1.5.2) lib/rack/head.rb:11:in `call'
  actionpack (4.1.9) lib/action_dispatch/middleware/params_parser.rb:27:in `call'
  actionpack (4.1.9) lib/action_dispatch/middleware/flash.rb:254:in `call'
  rack (1.5.2) lib/rack/session/abstract/id.rb:225:in `context'
  rack (1.5.2) lib/rack/session/abstract/id.rb:220:in `call'
  actionpack (4.1.9) lib/action_dispatch/middleware/cookies.rb:562:in `call'
  activerecord (4.1.9) lib/active_record/query_cache.rb:36:in `call'
  activerecord (4.1.9) lib/active_record/connection_adapters/abstract/connection_pool.rb:621:in `call'
  actionpack (4.1.9) lib/action_dispatch/middleware/callbacks.rb:29:in `block in call'
  activesupport (4.1.9) lib/active_support/callbacks.rb:82:in `run_callbacks'
  actionpack (4.1.9) lib/action_dispatch/middleware/callbacks.rb:27:in `call'
  actionpack (4.1.9) lib/action_dispatch/middleware/reloader.rb:73:in `call'
  actionpack (4.1.9) lib/action_dispatch/middleware/remote_ip.rb:76:in `call'
  better_errors (1.0.1) lib/better_errors/middleware.rb:84:in `protected_app_call'
  better_errors (1.0.1) lib/better_errors/middleware.rb:79:in `better_errors_call'
  better_errors (1.0.1) lib/better_errors/middleware.rb:56:in `call'
  actionpack (4.1.9) lib/action_dispatch/middleware/debug_exceptions.rb:17:in `call'
  actionpack (4.1.9) lib/action_dispatch/middleware/show_exceptions.rb:30:in `call'
  railties (4.1.9) lib/rails/rack/logger.rb:38:in `call_app'
  railties (4.1.9) lib/rails/rack/logger.rb:20:in `block in call'
  activesupport (4.1.9) lib/active_support/tagged_logging.rb:68:in `block in tagged'
  activesupport (4.1.9) lib/active_support/tagged_logging.rb:26:in `tagged'
  activesupport (4.1.9) lib/active_support/tagged_logging.rb:68:in `tagged'
  railties (4.1.9) lib/rails/rack/logger.rb:20:in `call'
  quiet_assets (1.0.2) lib/quiet_assets.rb:18:in `call_with_quiet_assets'
  actionpack (4.1.9) lib/action_dispatch/middleware/request_id.rb:21:in `call'
  rack (1.5.2) lib/rack/methodoverride.rb:21:in `call'
  rack (1.5.2) lib/rack/runtime.rb:17:in `call'
  rack (1.5.2) lib/rack/lock.rb:17:in `call'
  actionpack (4.1.9) lib/action_dispatch/middleware/static.rb:84:in `call'
  lib/gitlab/middleware/static.rb:9:in `call'
  rack (1.5.2) lib/rack/sendfile.rb:112:in `call'
  rack-mini-profiler (0.9.0) lib/mini_profiler/profiler.rb:298:in `call'
  railties (4.1.9) lib/rails/engine.rb:514:in `call'
  railties (4.1.9) lib/rails/application.rb:144:in `call'
  railties (4.1.9) lib/rails/railtie.rb:194:in `method_missing'
  rack (1.5.2) lib/rack/builder.rb:138:in `call'
  rack (1.5.2) lib/rack/urlmap.rb:65:in `block in call'
  rack (1.5.2) lib/rack/urlmap.rb:50:in `call'
  unicorn (4.6.3) lib/unicorn/http_server.rb:552:in `process_client'
  unicorn-worker-killer (0.4.2) lib/unicorn/worker_killer.rb:51:in `process_client'
  unicorn (4.6.3) lib/unicorn/http_server.rb:632:in `worker_loop'
  unicorn (4.6.3) lib/unicorn/http_server.rb:500:in `spawn_missing_workers'
  unicorn (4.6.3) lib/unicorn/http_server.rb:511:in `maintain_worker_count'
  unicorn (4.6.3) lib/unicorn/http_server.rb:277:in `join'
  unicorn (4.6.3) bin/unicorn_rails:209:in `<top (required)>'
      • Valery Sizov
        Valery Sizov @vsizov ·
        Contributor

        @DouweM Are you going to fix it? or You want me to fix it?

      • Douwe Maan
        Douwe Maan @DouweM ·
        Maintainer

        @vsizov If you've got time now, go for it. I won't have time until tomorrow.

      • username-removed-444
        username-removed-444 @dzaporozhets ·
        Owner

        @valery please take this issue and assign to yourself

      • Valery Sizov Reassigned to @vsizov

        Reassigned to @vsizov

      • Valery Sizov Milestone changed to 7.9

        Milestone changed to 7.9

      • username-removed-444 Milestone removed

        Milestone removed

      • username-removed-444 Reassigned to @dzaporozhets

        Reassigned to @dzaporozhets

      • username-removed-444
        username-removed-444 @dzaporozhets ·
        Owner

        @valery will take #1180 (closed) and I take this one

      • username-removed-444 Milestone changed to 7.9

        Milestone changed to 7.9

      • username-removed-444
        username-removed-444 @dzaporozhets ·
        Owner

        So the problem was with annotated tags without message. I just fixed it in 06ad715e

      • username-removed-444
        username-removed-444 @dzaporozhets ·
        Owner

        So the problem was with annotated tags without message. I just fixed it in 06ad715e

      • username-removed-105950
        username-removed-105950 @nmav ·
        Author

        Thanks. Does this mean that https://gitlab.com/gnutls/gnutls/commits/master should now work?

      • Douwe Maan
        Douwe Maan @DouweM ·
        Maintainer

        @nmav the fix has yet to be deployed to GitLab.com, so no, not yet.

      • username-removed-105950
        username-removed-105950 @nmav ·
        Author

        Is there some estimate on when could that be?

      • username-removed-25949 mentioned in issue #111 (closed)

        mentioned in issue #111 (closed)

      • username-removed-108230
        username-removed-108230 @diafero ·

        (Commenting here in order to be subscribed. I couldn't find a button for that...)

      • Sid Sijbrandij
        Sid Sijbrandij @sytses ·
        Owner

        @marin This is for the gnutils migration http://article.gmane.org/gmane.comp.encryption.gpg.gnutls.devel/8043 when we can promise a patch release for this?

      • Sid Sijbrandij
        Sid Sijbrandij @sytses ·
        Owner

        We need to release bumped gitlab_git version.

      • Sid Sijbrandij
        Sid Sijbrandij @sytses ·
        Owner

        @marin is working on patching GitLab.com

      • username-removed-444
        username-removed-444 @dzaporozhets ·
        Owner

        We deployed the fixed version. Tags and commits pages are working now.

      • username-removed-105950
        username-removed-105950 @nmav ·
        Author

        The pages are now fully working. Thank you for the prompt fix.

      • username-removed-105950 Status changed to closed

        Status changed to closed

      • username-removed-108230
        username-removed-108230 @diafero ·

        Should this automatically fix all existing projects? The one I imported https://gitlab.com/alcugs/alcugs is still broken (error 404). Furthermore, I get an error 500 when I access my projects dashboard https://gitlab.com/dashboard/projects.

      • Valery Sizov
        Valery Sizov @vsizov ·
        Contributor

        @diafero I think in your case we can talk about this issue #1180 (closed) which has been fixed too, but not released yet.

      • username-removed-108230
        username-removed-108230 @diafero ·

        Oh, I see - thanks.

      • Sid Sijbrandij
        Sid Sijbrandij @sytses ·
        Owner

        @nmav You're welcome, let us know if there is anything else, feel free to /cc @Mention me.

      • username-removed-146353 mentioned in issue #173 (closed)

        mentioned in issue #173 (closed)

      • Nikola Milojevic mentioned in merge request !14785

        mentioned in merge request !14785

      Please register or sign in to reply