Repository.size returns a wrong result

Most probably it's related to cache but I'm not 100% sure.

We (me and @jnijhof) measured an actual result with

def measure
  total_size = 0

  Project.where("id < 200").each do |p|
    path_to_repo = File.expand_path(File.join(Gitlab.config.gitlab_shell.repos_path, p.path_with_namespace + ".git"))
    size = `du -sk #{path_to_repo}|awk '{ print $1}'`
    total_size = total_size + size.chomp.to_i
  end

  total_size / 1024
end

measure

For example Project.where("id < 200").sum(:repository_size) returns 23.51MB where real size is 488MB

@dzaporozhets @jacobvosmaer

nope, it's not a cache issue. I created repo locally and this is what I see du -h #{Project.first.repository.path} = 102M

and

Project.first.repository.size
 => 203.91
[16] pry(main)> 

Well I found a bug. https://gitlab.com/gitlab-org/gitlab_git/blob/master/lib/gitlab_git/repository.rb#L200 it shows the number of blocks instead of folder size. k should be added after -s. So it should look like -sk

Milestone changed to 8.5

mentioned in merge request gitlab_git!63 (merged)

https://gitlab.com/gitlab-org/gitlab_git/merge_requests/63

mentioned in commit gitlab_git@d05189dc

Shouldn't this issue be closed?

Uh yes

Status changed to closed