Skip to content

Viewing wiki page's latest version via version_id in URL loads page with "old version" warning

Summary

When viewing the latest version of a wiki page with the ?version_id=<commit_hash> parameter in the URL, the page will load with a warning that it's an old version.

Steps to reproduce

  1. Go to the Page History of any page and verify its (truncated) commit hash for the latest version.
  2. Get the full hash value from, e.g., git log on a clone of the wiki.
  3. Add ?version_id=<commit_hash> to the end of the page URL and load the page.

Expected behavior

The page should load normally, without any "old version" warning.

Relevant logs and/or screenshots

image001

Output of checks

Results of GitLab Application Check

$ sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
Checking GitLab Shell ...
 
GitLab Shell version >= 2.6.10 ? ... OK (2.6.10)
Repo base directory exists? ... yes
Repo base directory is a symlink? ... no
Repo base owned by git:git? ... yes
Repo base access is drwxrws---? ... yes
hooks directories in repos are links: ...
2/1 ... ok
2/2 ... ok
13/4 ... ok
11/6 ... ok
2/7 ... ok
13/8 ... ok
3/10 ... ok
13/11 ... ok
14/12 ... ok
14/13 ... ok
14/14 ... ok
13/18 ... ok
14/19 ... ok
2/20 ... ok
13/22 ... ok
2/24 ... ok
17/25 ... ok
17/27 ... ok
13/29 ... ok
2/31 ... ok
13/32 ... ok
13/33 ... ok
17/34 ... ok
17/37 ... ok
2/42 ... ok
2/43 ... ok
2/45 ... ok
18/46 ... ok
18/47 ... ok
13/48 ... ok
2/53 ... ok
18/54 ... ok
18/55 ... ok
Running /home/git/gitlab-shell/bin/check
Check GitLab API access: OK
Check directories and files:
        /home/git/repositories: OK
        /home/git/.ssh/authorized_keys: OK
Test redis-cli executable: redis-cli 2.8.4
Send ping to redis server: PONG
gitlab-shell self-check successful
 
Checking GitLab Shell ... Finished
 
Checking Sidekiq ...
 
Running? ... yes
Number of Sidekiq processes ... 1
 
Checking Sidekiq ... Finished
 
Checking Reply by email ...
 
Reply by email is disabled in config/gitlab.yml
 
Checking Reply by email ... Finished
 
Checking LDAP ...
 
LDAP is disabled in config/gitlab.yml
 
Checking LDAP ... Finished
 
Checking GitLab ...
 
Git configured with autocrlf=input? ... yes
Database config exists? ... yes
Database is SQLite ... no
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config outdated? ... no
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory setup correctly? ... yes
Init script exists? ... yes
Init script up-to-date? ... yes
projects have namespace: ...
2/1 ... yes
2/2 ... yes
13/4 ... yes
11/6 ... yes
2/7 ... yes
13/8 ... yes
3/10 ... yes
13/11 ... yes
14/12 ... yes
14/13 ... yes
14/14 ... yes
13/18 ... yes
14/19 ... yes
2/20 ... yes
13/22 ... yes
2/24 ... yes
17/25 ... yes
17/27 ... yes
13/29 ... yes
2/31 ... yes
13/32 ... yes
13/33 ... yes
17/34 ... yes
17/37 ... yes
2/42 ... yes
2/43 ... yes
2/45 ... yes
18/46 ... yes
18/47 ... yes
13/48 ... yes
2/53 ... yes
18/54 ... yes
18/55 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.1.0 ? ... yes (2.1.5)
Your git bin path is "/usr/bin/git"
Git version >= 1.7.10 ? ... yes (2.7.0)
Active users: 11
 
Checking GitLab ... Finished

Results of GitLab Environment Info

Installation from source at v8.4 on Ubuntu 14.04.3 LTS. Env info check fails because rubocop?

$ sudo -u git -H bundle exec rake gitlab:env:info
rake aborted!
LoadError: cannot load such file -- rubocop/rake_task
/home/git/gitlab/vendor/bundle/ruby/2.1.0/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:274:in `require'
/home/git/gitlab/vendor/bundle/ruby/2.1.0/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:274:in `block in require'
/home/git/gitlab/vendor/bundle/ruby/2.1.0/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:240:in `load_dependency'
/home/git/gitlab/vendor/bundle/ruby/2.1.0/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:274:in `require'
/home/git/gitlab/lib/tasks/rubocop.rake:2:in `<top (required)>'
/home/git/gitlab/vendor/bundle/ruby/2.1.0/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:268:in `load'
/home/git/gitlab/vendor/bundle/ruby/2.1.0/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:268:in `block in load'
/home/git/gitlab/vendor/bundle/ruby/2.1.0/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:240:in `load_dependency'
/home/git/gitlab/vendor/bundle/ruby/2.1.0/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:268:in `load'
/home/git/gitlab/vendor/bundle/ruby/2.1.0/gems/railties-4.2.4/lib/rails/engine.rb:658:in `block in run_tasks_blocks'
/home/git/gitlab/vendor/bundle/ruby/2.1.0/gems/railties-4.2.4/lib/rails/engine.rb:658:in `each'
/home/git/gitlab/vendor/bundle/ruby/2.1.0/gems/railties-4.2.4/lib/rails/engine.rb:658:in `run_tasks_blocks'
/home/git/gitlab/vendor/bundle/ruby/2.1.0/gems/railties-4.2.4/lib/rails/application.rb:452:in `run_tasks_blocks'
/home/git/gitlab/vendor/bundle/ruby/2.1.0/gems/railties-4.2.4/lib/rails/engine.rb:453:in `load_tasks'
/home/git/gitlab/vendor/bundle/ruby/2.1.0/gems/railties-4.2.4/lib/rails/railtie.rb:194:in `public_send'
/home/git/gitlab/vendor/bundle/ruby/2.1.0/gems/railties-4.2.4/lib/rails/railtie.rb:194:in `method_missing'
/home/git/gitlab/Rakefile:7:in `<top (required)>'
(See full trace by running task with --trace)

Possible fixes

Maybe here? I'm not too familiar with

a) Ruby

  1. the GitLab codebase