new sidebar feedback

1. when editing a dropdown, but not changing anything you end up in an ugly state:

2. the hover-over state for the subscribe and other buttons are veeery subtle

3. the collapse button needs some sort of hover-over state

4. the reference gets shortened. This kind of misses the point ;-) TBH I think we can get rid of this, as we generate them automatically, but we should at least show it all.

5. the minimized sidebar is not functional. The copy button doesn't do anything

6. weight disappeared! It's only visible in the minimized sidebar

Safari

Reassigned to @jschatz1

• When collapsed, the RSS icon, which I guess represents subscription, should show the subscription status with a tooltip, and work as a toggle link.
• The pasteboard icon for the cross-reference link should also work as a button to copy it.
• It would be nice if the assignee icon showed the person's name in a tooltip. It could also show their avatar.
• The milestone incorrectly has the weight icon.
• The milestone name can be too long
• The milestone icon doesn't link.

mentioned in issue #3981 (closed)

Thanks everyone for feedback.

@jschatz1 please collaborate with @creamzy and lets get it improved before 8.5

Milestone changed to 8.5

Added frontend label

Even worse for me in both Safari and Chrome with inputs customisation.

When collapsed, the RSS icon, which I guess represents subscription, should show the subscription status with a tooltip, and work as a toggle link.

Let's show status in tooltip 4sure, as for toggle, I do agree that clicking on it should subscribe/unsubscribe a user, but we need to show the update in the tooltip : like on hover -> tooltip "unsubscribed" - > click - > tooltip "subscribed"

The pasteboard icon for the cross-reference link should also work as a button to copy it.

It makes sense only for chrome, as auto copy does not work for safari, but still yes please.

It would be nice if the assignee icon showed the person's name in a tooltip. It could also show their avatar.

@DouweM if someone is assigned, avatar is there. I support idea about tooltip, as we already have it for participants heads

The milestone incorrectly has the weight icon.

It's related to Jobs's bug about loosing weight in open sidebar

The milestone name can be too long

Cut the name ! and show full name in tooltip please.

The milestone icon doesn't link.

As currently milestone icon is hidden somewhere, as soon as it will arise before our eyes, it will be supper awesome to link it, as it's in the open sidebar. Whatever is linked there and is visible in the small sidebar, it should be linked in small as well (we can't do it for labels and participants obviously)

@creamzy @jschatz1 what if we automatically collapse sidebar when you navigate to merge request -> changes tab? I think when doing code review you care about the code so it should be a main focus on such page. At least when you are from laptop. It would be annoying to manually collapse sidebar every time you want to browse diff.

@dzaporozhets Does that mean that if you navigate from discussion -> diff, it collapses. If you navigate from diff -> discussion it should expand?

@jschatz1 as soon as it's collapsed, let's keep it collapsed maybe? Thank you for taking all the feedback!

weight disappeared! It's only visible in the minimized sidebar

@JobV and everyone, let me remind you that the weight feature is EE-only so you won't be able to see it in dev.gitlab.org ;)

What you see is an incorrect icon placed where the milestone is, as @DouweM suggested.

---

And my feedback on usability:

1. It's strange that in firefox (44.0) the collapse button is not clickable in dev but it's ok in GDK.
2. I'm still not able to scroll all the way down in my small screen and the copy url is hidden.
3. What is the need of having previous/next issues/MRs? I kinda like it but wouldn't it be better to go through the opened ones?

mentioned in commit ebeb35a0

mentioned in merge request !2736 (merged)

@skyruler Looks ok for me in Safari. Can you give me more details? Safari Version/OSX version.

Does that mean that if you navigate from discussion -> diff, it collapses. If you navigate from diff -> discussion it should expand?

@jschatz1 yes

mentioned in issue #13350 (closed)

The new sidebar has looked bad for me ever since it was introduced, but oddly it doesn't seem to be that way for everyone?

---

Chrome:

---

Firefox:

---

Safari:

---

Note the lack of padding on the right side.

@rspeicher I have the same bug :( and sometimes even double scroll

@rspeicher @creamzy os version and browser versions would be helpful.

@jschatz1

• OS X El Capitan
• Safari 9.0.2
• Google Chrome Version 48.0.2564.97 (64-bit)

@jschatz1

• OS X: El Capitan 10.11.2
• Chrome: 48.0.2564.109
• Firefox: 44.0.2
• Safari: 9.0.2 (11601.3.9)

mentioned in issue #13477 (closed)

I am seeing the double scrollbars on the sidebar in Chrome 48.0.2564.103 m Windows 10. originally noted in #13477 (closed) bringing over comment as requested.

---

It looks like the "right-sidebar" selector in issuable.scss is set to overflow: scroll. It should really be overflow: auto or else it will always render a scrollbar even if its not needed (content big enough to fit). Switching it to auto in developer tools fixes the issue for me.

https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/stylesheets/pages/issuable.scss#L156

I think this is an issue with OS X's scroll bar behavior. You can change the way it works in System Preferences > General > Show scroll bars

I think @jschatz1 and I have it enabled only when scrolling, so it's not really as much of an issue for us, whereas @rspeicher and @creamzy have scrollbars on Always Show. Can you all confirm?

@connorshea Good call, I have it set to "Always".

Oddly if you load the page, change the setting and then change it back, the sidebar looks fine until the next load.

If "Always" is the default (I think it is? Not entirely sure) we should definitely prioritize that issue. I'm not sure which is the default, anyone want to sacrifice themselves and reset their System Preferences? :P

Oh, actually Windows has scrollbars as its default for all browsers if I remember correctly. So regardless of whether or not it's default for Mac, we should fix this. (@jschatz1 scrollbars suck, been there done that. God help you.)

mentioned in issue #13466 (closed)

I have the same issue on Windows 10 with Firefox 44.0.2:

Also, two other notes here:

• The height of the section with the previous and next button should be the same as the section with the new issue button for visual consistency (as it is in @creamzy's design, see https://gitlab.com/gitlab-org/gitlab-ce/issues/3981#note_3132797)
• The total number of issues seems to be off here (13353 of 5552 doesn't really make sense since the issue number is higher than the total number). I'm guessing that 5552 is the number of open issues, but still it would make more sense if it were either the issue number + the total number of issues or the issue position within the open issues + the total number of open issues.

The total number of issues seems to be off here (13353 of 5552 doesn't really make sense since the issue number is higher than the total number). I'm guessing that 5552 is the number of open issues, but still it would make more sense if it were either the issue number + the total number of issues or the issue position within the open issues + the total number of open issues.

@TR4Android As I said in !2736 (merged), I fixed that in !2818 (merged). :)

Sidebar expansion goes crazy sometimes on small screens.

Normal expansion

Crazy expansion

I would guess it's the image in that issue but I haven't dug into it.

Status changed to closed by merge request !2736 (merged)

mentioned in commit 7cc4b739