Note notification is not send to the author of a commit when using groups

When the author of a commit is listed in the group members of a project, he does not receive note notifications. In the notification service, node.commit_author is called to get the user info. To fix this issue i patched my code of commit_author function in the note model like this :

  def commit_author
    @commit_author ||=
      project.users.find_by_email(noteable.author_email) ||
      project.users.find_by_name(noteable.author_name) ||
      project.group.users.find_by_email(noteable.author_email) ||
      project.group.users.find_by_name(noteable.author_name)
  rescue
    nil
  end

Is this going to be merged? The bug causes trouble for my team.

@raphael.rondeau Is this still an issue in latest GitLab?

@dblessing Dont know, i am not using gitlab anymore, sorry

I am closing this issue for now since we can't confirm whether it's still an issue in latest GitLab. If anyone of the above can confirm we can reopen. Thanks.

Status changed to closed

I'm pretty sure this is still happening. I never see my own notes via e-mail.

mentioned in commit d819b9d4

mentioned in merge request !14785