Developers can't close MR

ZD: https://gitlab.zendesk.com/agent/tickets/15784

Description

Developers are not able to close Merge Requests as the close button is not available for MRs that aren't their own. From the documentations perspective (https://gitlab.com/help/permissions/permissions) its understood that a "Manage merge requests" permission should be sufficient.

But by looking at the code (https://gitlab.com/gitlab-org/gitlab-ee/blob/master/app/models/ability.rb) I only see the "update_merge_request" permission for masters and higher (which is the permission that is used for this check: https://gitlab.com/gitlab-org/gitlab-ee/blob/master/app/views/projects/merge_requests/show/_mr_title.html.haml ).

Is this intended and the documentation is just wrong? Or is it possible to give this permission to the developers role?

---

@JobV Is this intended? If so do you think it makes sense that Manage MR also includes closing those from other devs or should we make this clear from our documentation?

/cc @pbouillet

Thanks for the creation of the issue @balameb! I really do hope that not only masters of a project are intended to close MRs of others, because the other rights that come with this role are not intended for anyone (and for us, closing a MR - which marks the MR as resolved - is something that every developer has to do often enough due to the other already reported problem that rebasing is technically not allowed - and will never be).

@rspeicher do you have any thoughts on this?

I think this is just a case of the documentation and the code not being in sync.

I'm not sure if the code is right, however. To me, "manage merge requests" should include the ability to close them. We either need to move that ability to the Developer level, or update the documentation to add the update_merge_request ability.

@rspeicher @balameb @pbouillet I think developers should be able to close MRs, like they are able to close issues.

@dzaporozhets agree?

I think developers should be able to close MRs, like they are able to close issues.

@JobV agree

P.S. I think its ok to give "Developer" role more permissions in collaboration so people use "Master" role mostly for administrative tasks like editing project, setting up protected branches, adding deploy keys etc.

Basically it would be great to end up with situation when "Master" role necessary only to access anything in "Settings" tab. And manage members of course.

Milestone changed to 8.7

mentioned in commit e6204eb3

mentioned in merge request !3099 (merged)

Reassigned to @rspeicher

Status changed to closed by commit e6204eb3

mentioned in commit e7c4c22c

I know this ticket is closed. But I had a question about the process we follow in our organization to close the request.

1. Devs develop a feature or fix an issue
2. they generate a merge request and assign to Repo Owner/master or QA team, depends upon what stage of the feature we are.
3. QA reviews the merge request, test on QA environment approve the merge request. The actual merge only happens by masters.
4. QA again test on production and marks the merge requests as closed. The issues/bugs are part of merge request and until the branch is stable it cannot be merged to production.

Now QA team can have maximum reporter/developer permissions the main Problem here is they cannot close Merge requests. We need the developer/Reporter or some other role(apart from master) should be able to close the merge request. Any help here ?