Closed issues should be displayed differently

It would be great to have this, especially in combination with task lists. Right now we have issues with task lists where each task is a reference to an issue. If closed tasks were shown with strikethrough automatically that makes it much more visually clear what the status is.

Mentioned in issue #21179 (closed)

Mentioned in issue #21691 (closed)

Added ~874211 and removed ~480950 labels

Added ~164274 label

Milestone changed to %8.14

Mentioned in merge request !5993 (closed)

Reassigned to @rymai

Milestone changed to %8.15

changed milestone to %8.16

mentioned in merge request !8368 (closed)

This would be a really great value-add for us too. We always mention dependent issues in a parent issue and would be great to see visually which ones have been closed. I'd suggest applying a dedicated CSS style to all closed ones, so we can style it even further, if needed. For example, we'd like them grayed out and crossed out at the same time.

We'd also prefer the closed issue numbers being crossed out instead of adding brackets with "[closed]". Shorter and quicker to process.

changed milestone to %8.17

mentioned in issue #27589 (closed)

changed milestone to %9.0

mentioned in merge request !9462 (merged)

mentioned in issue #4058 (moved)

changed milestone to %9.1

@smcgivern : Is this deliverable for 9.1? Or stretch?

mentioned in issue #29444 (closed)

@victorwu I think @adamniedzielski has this issue, from a community contribution, in which case it's probably Stretch .

@victorwu Yes, I have a merge request open for this - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9462. Right now it introduces a performance degradation so we cannot merge it. We have an idea how to overcome this performance degradation, but it requires changes in our Markdown rendering mechanism. Currently I'm not able to tell how big the required changes may be - I have to look into the code and see how realistic our idea is. If this feature is important for you I can make it my priority.

@smcgivern in what capacity will this issue be tackled? only for system notes or also for in text issue mentions?

what about merge requests?

@dimitrieh We will do it both for issues and merge request. For sure it will work in user comments, but I'm not certain about system notes. I have to check if they go through the same pipeline or not.

I checked and it's working also for system notes.

added Stretch label

Thanks @smcgivern @adamniedzielski . I made this Stretch for 9.1. Please go ahead and manage the work as normal in the regular 9.1 workflow.

If it doesn't make it into 9.1, let's re-evaluate later as a candidate for 9.2, and consider any dependent issues. Thanks!

assigned to @adamniedzielski

added docs-missing label

closed via merge request !9462 (merged)

mentioned in commit 68a839c2

mentioned in issue #30913 (closed)

@dimitrieh https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9462 ended up adding the status context to all links that contain issuables instead of just issuable references. That does not seem like expected behavior after reading https://gitlab.com/gitlab-org/gitlab-ce/issues/1369#note_14400430. It can make sentences harder to read.

The implementation that landed [merged] for this issue [closed] makes this sentence hard to read.

@dimitrieh It is kind of awkward to read the status after the issuable number. The status is an adjective, which normally comes before the subject in English.

"See #123 [closed] for more info" is read as "See issue 123 closed for more info"

vs

"See [closed] #123 for more info" is read as "See closed issue 123 for more info"

It also seems to make more sense with an issuable comment, because the status is a modifier for the issuable, but it looks like it is attached to the comment.

"I mentioned this in #123 (comment 123) [closed]" is read as "I mentioned this in issue 123 comment closed"

vs

"I mentioned this in [closed] #123 (comment 123)" is read as "I mentioned this in closed issue 123 comment"

Edit: Updated to clarify this is about how references sound when you read them.

Let's chat #31584 (closed), since this issue is already closed.

@deckar01 Thanks for your input! I agree, the first iteration is definitely very basic when it comes to presentation. I suggest to move the discussion to https://gitlab.com/gitlab-org/gitlab-ce/issues/30913.

mentioned in issue #30916 (closed)

Thanks @adamniedzielski, it's great for seeing the status quickly.

But I don't like the visual style of it. For some reason the (closed) and (merged) text disrupt me when I'm reading a sentence containing a mentionable.

@dimitrieh What do you think if we would instead of:

Show it something like this:

Or maybe a simpler fix, show it as superscript:

Alternatively, we also might consider showing the status in the tooltip?

@to1ne Those options don't seem to fix your main issue. It disrupts you when you are reading, because it produces grammatically incorrect English sentences. You don't read formatting in your head, so more formatting is not going to fix the issue, unless it obscures the status to the point that you are no longer reading it. See https://gitlab.com/gitlab-org/gitlab-ce/issues/1369#note_27461481.

@deckar01 I don't like closed issue either, because it removes useful information, e.g.:

This issue is a duplicate of closed issue and as mentioned in closed issue all the discussions about this are in closed issue.

@to1ne I was trying to illustrate what people read in their head, not suggesting that we should change #123 to issue. I updated the comment to clarify.

@to1ne Meta: https://gitlab.com/gitlab-org/gitlab-ce/issues/1369#note_27461481 is a discussion. Any reason you didn't reply directly to it?

mentioned in issue #31584 (closed)

@deckar01 : let's move this discussion to https://gitlab.com/gitlab-org/gitlab-ce/issues/31584, since we already implemented a merge request for this particular issue here. And there's been a lot of changes. Let's start fresh with any new changes to be discussed in #31584 (closed).

mentioned in merge request !14785

Closed issues should be displayed differently

Designs

Child items ...

Activity

Admin message

Admin message

Closed issues should be displayed differently

Activity