Issue sidebar displays the weight text when collapsed

I think something in 8.5.1 introduced this. Collapse the sidebar in this issue and you'll see that the weight text doesn't hide.

cc @iamphill @alfredo1

mentioned in issue #13350 (closed)

Title changed from Issue sidebar displays the wheight text when collapsed to Issue sidebar displays the weight text when collapsed

@axil Thanks for the report! I checked and the bug was actually already there in 8.5.0 but we didn't see it because the text that should have been hidden was just out of the page. Then a sidebar fix made this bug visible: https://gitlab.com/gitlab-org/gitlab-ee/commit/11cb6e84fe64380a8f707d9d19602c08dcee4d2f

@jschatz1 @alfredo1 I find the CSS to hide elements when the right sidebar is collapsed a bit brittle in https://gitlab.com/gitlab-org/gitlab-ee/blob/v8.5.1-ee/app/assets/stylesheets/pages/issuable.scss#L206-215:

    .issuable-count,
    .issuable-nav,
    .assignee > *,
    .milestone > *,
    .labels > *,
    .participants > *,
    .light > *,
    .project-reference > * {
      display: none;
    }

because to fix this bug, we'd have to add .weight > * class to this list but shouldn't we use a generic class instead? Something like .hide-when-collapsed (not sure about the name, you'll probably come up with a better idea). That way, there will be no need to change the CSS in EE and that would prevent conflicts & errors in the future?

Milestone changed to 8.6

Added regression label

Reassigned to @iamphill

mentioned in commit 0bfb7124

mentioned in merge request !2968 (merged)

Milestone changed to 8.5

Status changed to closed by merge request !2968 (merged)

mentioned in commit 3510569e

mentioned in commit 4bff9daf

Mentioned in commit maxraab/gitlab-ce@3510569e