Add TODOs for each member when groups are tagged

Presently when a group is tagged, its members do not receive TODO entries. This would be useful when you want to notify entire teams to look at merge requests for example.

@dzaporozhets can this be tagged as a feature proposal please?

Added feature proposal label

@dbalexandre can the todos tag be added? Hopefully this is a quick win :)

Added ~113220 label

@DouweM this feature has also been requested by a customer: https://gitlab.zendesk.com/agent/tickets/19189 Can we schedule it?

/cc @JobV

Good one!

Added todos label

Milestone changed to 8.8

@dbalexandre I'll schedule for 8.8, but if you're doing a "todos improvements streak" before that, feel free to pick it up earlier.

Added ~12980 and removed feature proposal labels

@ahmadsherif Would you like to have a look here?

I just spent a little time with @ahmadsherif investigating this issue, and for us, mentioning a group did actually result in all group members getting a todo. From reviewing the code, it's worked that way since the release of the Todos feature.

The only explanation we have for a group mention not resulting in todos, is that it's permissions related: Either the user performing the group-mention doesn't have access to that group (the group may be private and the user may not be a member), or the members in that group don't have access to the project the group is being mentioned in.

@paulreid100 @patricio Can you see if any of these is the case?

@DouweM I tried again this morning and it still does not work in our case. The group owns the project, and the developers are all members of the group. No one is individually a member of the project, and the project visibility is set to "Internal". When the group is mentioned on a Merge Request for the project, no one receives a Todo.

If you need me to try anything else or provide any more info please let me know.

@paulreid100 All right, some followup questions:

• Is the group mention rendered as a link?
• Do you see all of the group members in the "Participants" section in the sidebar on the right?

@DouweM Yes for both questions.

@paulreid100 Can you reproduce this on GitLab.com?

@DouweM Yes, though I did things slightly differently for my test on GitLab.com. I created a new test group and added a friend, then created a new project under that group, then opened an issue and commented on it with a mention of the group. My friend did not receive a Todo notification, but he was added to the list of participants, and the mention was rendered as a link.

In this case, the group and the project were set to private.

I can confirm the bug now that I followed Paul's steps. It seems that Mentionable#all_references is called with current_user passed as nil explicitly, so no default argument (self.author) is used. If it can wait, I'll write a fix for it tonight.

@paulreid100 Thanks for following up!

@ahmadsherif Please do!

@DouweM I already did https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4081 :)

Status changed to closed by merge request !4081 (merged)

mentioned in commit ab4671f2

mentioned in issue #18033 (closed)