README rendering should only apply to text documents

GitLab will typically show the contents of a README file if it finds one in a given repo. The problem is that it shows the contents of any file, even if it's a binary file. For example, if an image file in the repo is named README.png, the contents of that image file are rendered when the README tab is clicked. I've also seen this occur with Microsoft Word documents (README.doc or README.docx).

Ideally, README files should only be rendered if they are plain-text files (not binary files). Perhaps a white-list of approved file extensions is the solution (e.g. README, README.txt, README.md, etc)?

Here's a screenshot of the issue in 7.9.1:

Added ~12742 label

Added markdown and removed ~12742 labels

I would go one step further and only apply it to .md files.

I migrated some of my project from github to gitlab and now the README files look horrible. The should be show as text in the terminal or an editor.

here is an example:

https://gitlab.com/pokermania/pokereval#tab-readme

vs.

https://github.com/pokermania/pokereval#readme

@hwmrocker Ugh, good point. READMEs without extensions should probably just be plainly-formatted in pre.

Judging from the test repo provided, I assume this is now resolved.

Status changed to closed

Status changed to reopened

I still see this issue with 8.1.2. I'm about to update to 8.1.3, so I'll report back with my findings once that's been done.

This problem is still present in 8.1.3.

@jgbishop Could you make a sample repository on gitlab.com, which reproduces this issue?

Sure thing. Here's a sample repo that demonstrates this issue.

mentioned in issue #3978 (closed)

closing in favor of #3978 (closed)

Status changed to closed

mentioned in merge request !14785