Skip to content

MergeRequest#show 500 error

https://gitlab.com/gitlab-org/omnibus-gitlab/merge_requests/307

This is probably the exception, looking at the logs:


ActionView::Template::Error (undefined method `short_id' for nil:NilClass):
     8:     %div
     9:       = link_to_member(@project, note.author, avatar: false)
    10:       started a discussion on commit
    11:       = link_to(note.noteable.short_id, namespace_project_commit_path(note.project.namespace, note.project, note.noteable), class: 'monospace')
    12:     .last-update.hide.js-toggle-content
    13:       - last_note = discussion_notes.last
    14:       last updated by
  app/views/projects/notes/discussions/_commit.html.haml:11:in `_app_views_projects_notes_discussions__commit_html_haml___4252815140094902839_115900360'
  app/views/projects/notes/_discussion.html.haml:13:in `_app_views_projects_notes__discussion_html_haml___432141495483595465_26242140'
  app/views/projects/notes/_notes.html.haml:7:in `block in _app_views_projects_notes__notes_html_haml__1123235883992916455_26949580'
  app/views/projects/notes/_notes.html.haml:2:in `each'
  app/views/projects/notes/_notes.html.haml:2:in `_app_views_projects_notes__notes_html_haml__1123235883992916455_26949580'
  app/views/projects/notes/_notes_with_form.html.haml:2:in `_app_views_projects_notes__notes_with_form_html_haml__2545555825534888609_27739740'
  app/views/projects/merge_requests/_discussion.html.haml:13:in `_app_views_projects_merge_requests__discussion_html_haml__1965882565308906701_41882900'
  app/views/projects/merge_requests/_show.html.haml:56:in `_app_views_projects_merge_requests__show_html_haml__464208771020676341_116043180'
  app/views/projects/merge_requests/show.html.haml:1:in `_app_views_projects_merge_requests_show_html_haml__27721185065583191_115855380'
  app/controllers/projects/merge_requests_controller.rb:39:in `show'

This is a MR across projects. I recently added a reference namespace/project@commit in a comment, I wonder if that has something to do with it.