Diff Redesign

Per https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/3275 let's finish up the redesign of this page per the designs that @skyruler so beautifully put together.

cc @iamphill @alfredo1 @elvongray

mentioned in merge request !3275 (merged)

Design screenshot uses regular font but we should continue use monospace for diff. The rest seems ok

@jschatz1 >< keep up the good work

Reassigned to @annabeldunstone

@skyruler Does this (gitlab1.atype) include everything that needs to be changed for the diff pages?

@annabeldunstone no I think it was updated on a different pages several time, unfortunately this one is not final

@skyruler Is it this one?? If it isn't this one can you link us to the right one?

@jschatz1 Liza is also was working for changing color theme to suit color blind people, there was tons of small issues regarding diff, everything should be in gitlab1 file. @dzaporozhets do you remember that issue about color blind color theme?

mentioned in merge request !3476 (merged)

@skyruler @jschatz1 @dzaporozhets The colors vary slightly across the different layers in gitlab1. Should I use the colors from ELEMENT: diffs color for now?

In addition, the current icon we are using for text files is set in icons_helper.rb as file-text-o. It looks like the new design is using file-o. Do we want to change the fallback file icon to file-o?

Old icon:

New icon:

@annabeldunstone https://gitlab.com/gitlab-org/gitlab-ce/issues/13500 - this is sorta final diff with right colors and fonts :) cc @jschatz1.

@annabeldunstone good idea with icons!

@annabeldunstone good that you asked. See @skyruler response. He is master of colors in GitLab

Thanks guys.

Status changed to closed by commit 593972ca

mentioned in commit 593972ca

Mentioned in commit pfjason/gitlab-ce@593972ca