"Upcoming Milestone" option is gone from milestone dropdown

Was introduced in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/3148 for 8.6, and then accidentally removed with the new dropdowns :)

cc @jschatz1

mentioned in issue #14303 (closed)

cc @iamphill

Reassigned to @iamphill

I've just added it back in & if the only milestone you have is one with a past date then it throws an error. Should it always be present in the milestone dropdown? I never remember seeing it

@iamphill you mean it currently throws an error?

It won't on https://gitlab.com/gitlab-org/gitlab-ce because we have milestones in the future. However on my local, I had 1 milestone in the past and it throws an error.

I'll fix it with my MR

mentioned in merge request !3368 (merged)

and did it used to work on dashboard/issues?

You can see the above error on https://gitlab.com/iamphill/test/issues?scope=all&sort=id_desc&state=opened&utf8=%E2%9C%93&milestone_title=%23upcoming which is filtering by upcoming with only a milestone in the past

!3368 (merged) will fix the error

Status changed to closed by merge request !3368 (merged)

mentioned in commit 07a4aaca

mentioned in commit 4a439856