Comment text remains in text box after submitting it (Comment and close)

Description

Comment box remains the same text after submitting comment via Comment and Close

Steps to reproduce

1. Create a comment
2. Click on Comment and Close

Expected behaviour

1. Issue/MR is closed and comment is posted
2. Comment box is empty

Observed behaviour

1. Issue/MR is closed and comment is posted
2. Comment box still shows the posted comment

mentioned in issue #1438 (closed)

I couldn't reproduce this on the v7.10.0.rc8 tag and on master. The text is supposed to be cleared upon a successful Ajax post. Anyone else running into this?

I haven't had that issue when i comment & close but sometimes I get it after a normal comment.
I can't reproduce it reliable. I'll take a look at the browser console next time I see it.

Reproducible for on 7-10 stable (own system) and gitlab.com. I'm on OSX, Safari 8.0.3

@razer6 do you get any errors in the browser console?

Nope

I reproduced this problem in Safari but not in Chrome or Firefox. It seems that for some reason, clicking on "Close and Comment" button is firing the ajax:error event instead of the ajax:success event. You can see the first XHR POST request to post the note, followed by another POST to close the event:

The XHR status:

{
  "readyState": 0,
  "responseText": "",
  "status": 0,
  "statusText": "error"
}

What do the status codes mean? This document suggests that the XHR request was never sent.

I think the second POST is causing a whole page refresh, which causes Safari to abort any outstanding XHR requests. When I change the submit anchor to use data-remote: true, both comment and close work requests go through fine but the page is not updated to refreshed to show the Closed state.

I think the right solution is to wait for the comment request to finish successfully before initiating the close event and whole page refresh. Unfortunately, I haven't figured out how to prevent the Close button from refreshing the whole page. Adding e.preventDefault() and return false to the click handler doesn't seem to change anything. There may a higher precedence click handler that causes this, but I haven't been able to figure out what that is.

mentioned in issue #2014 (closed)

This happens still in 7.13RC3

mentioned in issue #2213 (closed)

I can think of two ways of fixing this:

1. Change the "comment & close" button to be a remote: true field, and we use the JS response to change the button type.
2. We add a param to the redirect_to in IssuesController#Update that we will check upon when redirecting back to the overview page, and then clear the text box.

Any other suggestions?

Milestone removed

mentioned in issue #2845 (closed)

I see this on El Capital running Safari using GitLab.com, as of today.

Don't remember it before, but could have been occurring for a long time. But just saw this ticket and wanted to up-vote.

mentioned in issue #3959 (closed)

mentioned in merge request !2164 (merged)

Added frontend label

mentioned in issue #4207 (closed)

mentioned in issue #7961 (closed)

I saw this pop up again with the current RC on firefox.
It seems that the last state of the div isn't changed, because when you click on Preview before submitting the comment it stays on the preview tab.

Reassigned to @jschatz1

mentioned in commit 604a811f

mentioned in merge request !2452 (merged)

Status changed to closed by commit 604a811f

mentioned in commit 72a8c2b3

mentioned in commit 5433637d

Mentioned in commit pfjason/gitlab-ce@5433637d