Search Design Fixes and Bugs

1. X button shouldn't clear the search context. Just the text IMO.
2. If you type in a search and it comes up with the project it shouldn't redirect to the same page, it should just put the context pill back in.
3. Do these two colors look the same to you? Did you use the designs??? #4f91f8:
   
   
4. Those two search boxes are completely different sizes.
5. Does this X's color look like the design? I understand we are using Font Awesome but at least get the color right. Use some slightly disabled color. I got #807E7E
   
   

mentioned in merge request !3212 (merged)

Regarding the first item of the list. The design suggest we can remove the search context when we focus the input even if empty

If you type in a search and it comes up with the project it shouldn't redirect to the same page, it should just put the context pill back in.

@jschatz1 We might do this on the backend. Results can exclude current project since we are passing project_id

@alfredo1 I don't think you want to do that. What if they delete their context pill thing, and they want to get it back?

@jschatz1 If the user deletes the context they can bring it back by pressing escape. I'll fix it on the frontend anyway.

mentioned in merge request !3475 (merged)

Regarding the first item of the list. The design suggest we can remove the search context when we focus the input even if empty

@jschatz1 What's your opinion on this. Still want me do to this?:

X button shouldn't clear the search context. Just the text IMO

If not MR is ready at https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/3475

Reassigned to @jschatz1

Regarding:

X button shouldn't clear the search context. Just the text IMO

I think you should do it! I still think that applies. If they want to clear the context they can use their delete key.

Reassigned to @alfredo1

Status changed to closed by commit b6d5fcd4

mentioned in commit b6d5fcd4