Login / Signup page markup breaks 1Password

Hi,

I'm really liking gitlab.com so far as an alternative to the usual suspects, but there is one issue that is pretty annoying. I can't easily use 1Password to login, actually no one can use 1Password to login.

The issue is that on https://gitlab.com/users/sign_in both the 'Sign In' and 'Sign Up' forms share too much markup. Both forms use the same ID, which is in and of itself a no-no the forms also share the same name for the password field (specifically user[password]).

It should be pretty trivial to give each form a unique ID and to adjust the form field names to be entirely unique between the forms. For example, I would suggest a naming convention of login[username], login[password] vs signup[username] and signup[password] to ensure password managers like 1Password don't become an annoyance to your users.

Interesting. I used 1Password to login here just yesterday and everything seemed to work as expected.

Still, this sounds like a reasonable adjustment we could make. cc @DouweM

It's possible I'm doing something wrong, but I triple checked the markup and 1Password web form details and with the fields named as they are I always end up filling in the first username/email field in the login form and the password field in the signup form.

Added ~12980 label

Milestone changed to 8.7

Milestone changed to 8.8

Yep, sounds like something we should fix!

Reassigned to @rspeicher

mentioned in commit a6ba8647

mentioned in merge request !3826 (merged)

mentioned in issue gitlab-com/www-gitlab-com#662 (closed)

Status changed to closed by commit a6ba8647

mentioned in commit 622ad235

@frankwiles So in 8.8 the "new user" fields will get prefixed with new_user (e.g., new_user_password), so your existing 1Password entry should "just work" for logging in.

Awesome thanks! Can't wait until it gets rolled out on Gitlab.com so I can take advantage of it.

Mentioned in commit pfjason/gitlab-ce@a6ba8647

Mentioned in commit pfjason/gitlab-ce@622ad235