Fully clickable TODO row uses javascript and does not respect using CMD to open in new tab
Reproduce: Click on empty area with CMD
pressed. Item is opened in same tab.
As a person who use TODO's everyday its quite annoying behaviour. Please do something with it.
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Author Owner
Either make whole title a link and remove clickable js for row or make whole row a link.
- Contributor
whole row please
- Author Owner
Basically now I can not use
cmd+click
workflow because even if I click on issue link it will open link in new tab but also load it on current tab - username-removed-444 Added regression label
Added regression label
- Maintainer
I think we really only have 1 to solve this:
Clicking the row opens in the current tab. If you click on the link, it ignores the JS
Turbolinks.visit
Does that sound ok?
- Annabel Gray Reassigned to @annabeldunstone
Reassigned to @annabeldunstone
- Contributor
I think this occurs because all clicks to the todo row causes
Turbolinks.visit
to be called, even if it is a link that is clicked. https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/javascripts/todos.js.coffee#L14 - Annabel Gray mentioned in merge request !3623 (merged)
mentioned in merge request !3623 (merged)
- Jacob Schatz Status changed to closed by commit 0d216c19
Status changed to closed by commit 0d216c19
- Jacob Schatz mentioned in commit 0d216c19
mentioned in commit 0d216c19
- Robert Speicher Status changed to reopened
Status changed to reopened
- Annabel Gray mentioned in issue #15052 (closed)
mentioned in issue #15052 (closed)
- Maintainer
@rspeicher why did you reopen it?
- Owner
On mobile, must've been a misclick.
- Robert Speicher Status changed to closed
Status changed to closed
- Maintainer
This issue has to do with turbo links. Apparently it it appears that you cannot use command click with turbo links. I'm not sure if this is true globally. But if it is we need to fix it and many other places and make a global solution. I'm shocked that turbo links would have this issue. But I can't seem to see any other reason why it happens at the moment.
- Developer
Are we on the latest version of Turbolinks 2.x? If not, check the Changelog to see if it's a bug they've fixed.
- yorickpeterse-staging mentioned in issue #14939 (closed)
mentioned in issue #14939 (closed)