Can't tag repositories

1. Summary: Settings-view for repositories break when updating tags
2. Steps to reproduce: create a repo, go to settings, add tags, click on save changes
3. Expected behavior: see above
4. Observed behavior When also updating the image => Error 500 otherwise: endless loading...
5. Relevant logs and/or screenshots:

Started PATCH "/GRa/gra" for 131.188.6.45 at 2015-04-25 18:15:55 +0200
Processing by ProjectsController#update as JS
  Parameters: {"utf8"=>"✓", "authenticity_token"=>"[FILTERED]", "project"=>{"name"=>"<name>", "description"=>"<desc>", "visibility_level"=>"<v>", "tag_list"=>"uni, tex", "issues_enabled"=>"<i>", "merge_requests_enabled"=>"<m>", "wiki_enabled"=>"<w>", "snippets_enabled"=>"<s>"}, "commit"=>"Save changes", "namespace_id"=>"<ns>", "id"=>"<id>"}
Mysql2::Error: Unknown column 'taggings_count' in 'field list': UPDATE `tags` SET `taggings_count` = COALESCE(`taggings_count`, 0) + 1 WHERE `tags`.`id` = 41
Completed 500 Internal Server Error in 298ms

6. Output of checks
   • Results of GitLab Application Check:

Checking Environment ...

Git configured for git user? ... yes

Checking Environment ... Finished

Checking GitLab Shell ...

GitLab Shell version >= 2.6.2 ? ... OK (2.6.2)
Repo base directory exists? ... yes
Repo base directory is a symlink? ... no
Repo base owned by git:git? ... yes
Repo base access is drwxrws---? ... yes
Satellites access is drwxr-x---? ... yes
hooks directories in repos are links: ... 
6/6 ... ok
3/9 ... ok
3/10 ... ok
3/11 ... ok
3/12 ... ok
3/14 ... ok
8/15 ... ok
10/18 ... ok
10/19 ... ok
3/20 ... ok
3/21 ... ok
12/22 ... repository is empty
Running /home/git/gitlab-shell/bin/check
Check GitLab API access: OK
Check directories and files: 
        /home/git/repositories/: OK
        /home/git/.ssh/authorized_keys: OK
Test redis-cli executable: redis-cli 3.0.0
Send ping to redis server: PONG
gitlab-shell self-check successful

Checking GitLab Shell ... Finished

Checking Sidekiq ...

Running? ... yes
Number of Sidekiq processes ... 1

Checking Sidekiq ... Finished

Checking LDAP ...

LDAP is disabled in config/gitlab.yml

Checking LDAP ... Finished

Checking GitLab ...

Database config exists? ... yes
Database is SQLite ... no
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config outdated? ... no
Log directory writable? ... yes
Tmp directory writable? ... yes
Init script exists? ... yes
Init script up-to-date? ... yes
projects have namespace: ... 
6/6 ... yes
3/9 ... yes
3/10 ... yes
3/11 ... yes
3/12 ... yes
3/14 ... yes
8/15 ... yes
10/18 ... yes
10/19 ... yes
3/20 ... yes
3/21 ... yes
12/22 ... yes
Projects have satellites? ... 
6/6 ... yes
3/9 ... yes
3/10 ... yes
3/11 ... yes
3/12 ... yes
3/14 ... yes
8/15 ... yes
10/18 ... yes
10/19 ... yes
3/20 ... yes
3/21 ... yes
12/22 ... can't create, repository is empty
Redis version >= 2.0.0? ... no
  Try fixing it:
  Update your redis server to a version >= 2.0.0
  For more information see:
  gitlab-public-wiki/wiki/Trouble-Shooting-Guide in section sidekiq
  Please fix the error above and rerun the checks.
Ruby version >= 2.0.0 ? ... yes (2.1.4)
Your git bin path is "/usr/bin/git"
Git version >= 1.7.10 ? ... yes (1.9.1)
Active users: 5

Checking GitLab ... Finished

* Version of GitLab: `7-10-stable`
* last commit SHA-1 of the GitLab version: a651951723269ff414fb1047e83b5075a5733533
* Describe your setup (`sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`): `DB Adapter:     mysql2`

It looks like this issue:

http://stackoverflow.com/questions/23239578/after-upgrading-to-rails-4-1-acts-as-taggable-on-is-not-working

It looks like we need to update the migrations from acts-as-taggable-on. When I added them and excluded the migration to add the tags and taggings table, tags worked again. I'll submit a MR.

Thank you.

sudo -u git -H bundle exec rake acts_as_taggable_on_engine:install:migrations RAILS_ENV=production
Copied migration 20150425170143_acts_as_taggable_on_migration.acts_as_taggable_on_engine.rb from acts_as_taggable_on_engine
Copied migration 20150425170144_add_missing_unique_indices.acts_as_taggable_on_engine.rb from acts_as_taggable_on_engine
Copied migration 20150425170145_add_taggings_counter_cache_to_tags.acts_as_taggable_on_engine.rb from acts_as_taggable_on_engine
Copied migration 20150425170146_add_missing_taggable_index.acts_as_taggable_on_engine.rb from acts_as_taggable_on_engine
Copied migration 20150425170147_change_collation_for_tag_names.acts_as_taggable_on_engine.rb from acts_as_taggable_on_engine

But this did not fix the problem...

mentioned in merge request !577 (merged)

@sedrubal The MR is in !577 (merged). If you wanted to migrate before the official release, you would have to remove the first migration since it conflicts with the existing table and run gitlab-ctl reconfigure.

mentioned in issue #1438 (closed)

Status changed to closed by commit 44afcd20

Oops. I don't have Omnibus and so I don't have gitlab-ctl. Can I do this manually?

Are you installing from source? This should now be on master, and you can run the db:migrate task:

sudo -u git -H bundle exec rake db:migrate RAILS_ENV=production

yes, I'm installing from source.

My problem is, that I ran sudo -u git -H bundle exec rake acts_as_taggable_on_engine:install:migrations RAILS_ENV=production before, as it is mentioned on StackOverflow. But at that time, it didn't work (but I didn't understand this ). And so rake aborts now:

Mysql2::Error: Table 'tags' already exists: CREATE TABLE `tags` (`id` int(11) auto_increment PRIMARY KEY, `name` varchar(255)) ENGINE=InnoDB/home/git/gitlab/vendor/bundle/ruby/2.1.0/gems/activerecord-4.1.9/lib/active_record/connection_adapters/abstract_mysql_adapter.rb:303:in `query'

Deleting the tags table won't be a good idea, I think...

I think that's okay; the migrations didn't do anything because the first one failed. You probably have unchecked migrations in your directory that you should clean. Doing a git status should show them. You should remove them and pull from GitLab master.

Thank you very much ;)

mentioned in commit tnir/gitlab-ce@81634bc1