Simplify Gitlab::UrlBuilder
$ git grep Gitlab::UrlBuilder
app/services/issues/base_service.rb: issue_url = Gitlab::UrlBuilder.new(:issue).build(issue.id)
app/services/merge_requests/base_service.rb: merge_request_url = Gitlab::UrlBuilder.new(:merge_request).build(merge_request.id)
app/views/search/results/_note.html.haml:- note_url = Gitlab::UrlBuilder.new(:note).build(note.id)
lib/gitlab/note_data_builder.rb: Gitlab::UrlBuilder.new(:note).build(note.id)
spec/lib/gitlab/note_data_builder_spec.rb: let(:note_url) { Gitlab::UrlBuilder.new(:note).build(note.id) }
spec/lib/gitlab/url_builder_spec.rb:describe Gitlab::UrlBuilder, lib: true do
spec/lib/gitlab/url_builder_spec.rb: url = Gitlab::UrlBuilder.new(:issue).build(issue.id)
spec/lib/gitlab/url_builder_spec.rb: url = Gitlab::UrlBuilder.new(:merge_request).build(merge_request.id)
spec/lib/gitlab/url_builder_spec.rb: let(:url) { Gitlab::UrlBuilder.new(:note).build(note.id) }
spec/lib/gitlab/url_builder_spec.rb: let(:url) { Gitlab::UrlBuilder.new(:note).build(note.id) }
spec/lib/gitlab/url_builder_spec.rb: let(:url) { Gitlab::UrlBuilder.new(:note).build(note.id) }
spec/lib/gitlab/url_builder_spec.rb: let(:url) { Gitlab::UrlBuilder.new(:note).build(note.id) }
spec/lib/gitlab/url_builder_spec.rb: let(:url) { Gitlab::UrlBuilder.new(:note).build(note.id) }
spec/lib/gitlab/url_builder_spec.rb: let(:url) { Gitlab::UrlBuilder.new(:note).build(note.id) }
By looking at this, it seems that we could simplify Gitlab::UrlBuilder
to take an object instead of its ID and to deduce the type from its class.
This would allow us to write Gitlab::UrlBuilder.build(issue)
.