Expose merge request id as a variable visible in CI

Right now it's not possible to find out whether a GitLab CI build is triggered by submitting a merge request. With merge request id provided, it'll possible to use tools like code coverage, static code analyzers and so on. Travis and CircleCI both expose something similar

Discussed a bit about it with @ayufan.

It also would be nice to have both id and iid of merge request to use it with GitLab REST API

Thanks.

@grzesiek Do you think that it would be enough to expose Build::merge_request to Runner and inject this information into build context?

Added wiki 2fa ~19173 labels

Removed 2fa wiki labels

@ayufan Yes, we can try adding something like:

variables << { key: :CI_BUILD_MR, value: merge_request.iid, public: true } if merge_request

to predefined variables. What do you think?

mentioned in issue #15310 (closed)

I think that we should expose all Merge Request related information: also in build API and also in variables.

@ayufan

Regarding merge_request.iid - I want to use this variable to get merge request changes by REST API and there I have to use global MR id, like this:https://gitlab.com/api/v3/projects/1071592/merge_requests/418901/changes, where this MR is returned as:

{
  "id": 418901,
  "iid": 2
}

So I think I rather need merge_request.id.

OK, just noticed that I can use GET /projects/:id/merge_requests?iid={iid} so it'd not be a problem.

@ayufan any updates on this?

@pjagielski Sorry, not yet. We will discuss that feature quite soon how and when we could implement this.

@pjagielski We are thinking about this: https://gitlab.com/gitlab-org/gitlab-ce/issues/17542. It will allow to solve it more easily.

mentioned in issue #20576 (moved)

@victorwu @ayufan - Is there any progress on this?

We're needing to know what MR caused a CI stage to trigger so we can do additional validation on the code that changed and the files that were changed in this specific merge request.

edit: Another use we're needing this for is to look at the commits in the MR so we can do commit message validation. Right now you can only do commit message validation for direct pushes to the upstream and not at the MR level.

@markpundsack : Is this on your radar from a CI perspective?

@victorwu Yes, it depends on #23902 (moved).

changed milestone to %Backlog

Not sure if this helps anyone but I was able to cobble this together with jq to get the variables I wanted:

export PR_BRANCH=$(curl -s "http://domain/api/v4/projects/${CI_PROJECT_ID}/merge_requests?private_token=${OAUTH_TOKEN}&state=opened" | jq -r ".[]|select(.sha == \"$CI_COMMIT_SHA\")|.source_branch")

export PR_ID=$(curl -s "http://domain/api/v4/projects/${CI_PROJECT_ID}/merge_requests?private_token=${OAUTH_TOKEN}&state=opened" | jq -r ".[]|select(.sha == \"$CI_COMMIT_SHA\")|.iid")

moved to gitlab#4683

Hey!

GitLab is moving all development for both GitLab Community Edition and Enterprise Edition into a single codebase. The current gitlab-ce repository will become a read-only mirror, without any proprietary code. All development is moved to the current gitlab-ee repository, which we will rename to just gitlab in the coming weeks. As part of this migration, issues will be moved to the current gitlab-ee project.

If you have any questions about all of this, please ask them in our dedicated FAQ issue.

https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

You can also find more information here:

• https://gitlab.com/gitlab-org/gitlab-ee/issues/13304
• https://about.gitlab.com/2019/08/23/a-single-codebase-for-gitlab-community-and-enterprise-edition/

Frequently Asked Questions

For an up to date list of questions and answers, please take a look at https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

What will we do with the repository names?

https://gitlab.com/gitlab-org/gitlab-ee/ will become https://gitlab.com/gitlab-org/gitlab, and https://gitlab.com/gitlab-org/gitlab-ce will become https://gitlab.com/gitlab-org/gitlab-foss.

Why rename gitlab-ce to gitlab-foss?

Using "gitlab" and "gitlab-ce" would be confusing, so we decided to rename gitlab-ce to gitlab-foss to make the purpose of this FOSS repository more clear

I created a merge requests for CE, and this got closed. What do I need to do?

You will need to create a merge request at https://gitlab.com/gitlab-org/gitlab-ee/. This link will eventually redirect to https://gitlab.com/gitlab-org/gitlab.

How does the licensing work in this new setup?

Everything in the ee/ directory is proprietary. Everything else is free and open source software. If your merge request does not change anything in the ee/ directory, the process of contributing changes is the same as when using the gitlab-ce repository.

Will you accept merge requests on the gitlab-ce/gitlab-foss project after it has been renamed?

No. Merge requests submitted to this project will be closed automatically.

Will I still be able to view old issues and merge requests in gitlab-ce/gitlab-foss?

Yes.

How will this affect users of GitLab CE using Omnibus?

No changes will be necessary, as the packages built remain the same.

How will this affect users of GitLab CE that build from source?

Once the project has been renamed, you will need to change your Git remotes to use this new URL. GitLab will take care of redirecting Git operations so there is no hard deadline, but we recommend doing this as soon as the projects have been renamed.

Where can I see a timeline of the remaining steps?

https://gitlab.com/gitlab-org/gitlab-ee/issues/13304

Will community contributions submitted to the new "gitlab" repository be available in the new gitlab-foss repository?

Yes, these changes will be synced to gitlab-foss automatically, several times per day.

locked this issue