ActionView::Template::Error: undefined method `change_type_title' for nil:NilClass

https://sentry.gitlap.com/gitlab/gitlabcom/issues/4288/

NoMethodError: undefined method `change_type_title' for nil:NilClass
  app/helpers/commits_helper.rb:150:in `cherry_pick_commit_link'
    tooltip = "Cherry-pick this #{commit.change_type_title} in a new merge request"
  app/views/projects/merge_requests/widget/_merged_buttons.haml:12:in `_app_views_projects_merge_requests_widget__merged_buttons_haml__3016672559654531416_54566540'
    = cherry_pick_commit_link(@merge_request.merge_commit, namespace_project_merge_request_path(@project.namespace, @project, @merge_request), btn_class: 'sm')
  app/views/projects/merge_requests/widget/_merged.html.haml:22:in `_app_views_projects_merge_requests_widget__merged_html_haml___1370597251318489830_55725220'
    = render 'projects/merge_requests/widget/merged_buttons', source_branch_exists: true
  app/views/projects/merge_requests/widget/_show.html.haml:4:in `_app_views_projects_merge_requests_widget__show_html_haml___2806373217290547563_55888060'
    = render 'projects/merge_requests/widget/merged'
  app/views/projects/merge_requests/_show.html.haml:40:in `_app_views_projects_merge_requests__show_html_haml__1045278443303219304_58187380'
    = render "projects/merge_requests/widget/show.html.haml"
...
(192 additional frame(s) were not displayed)

ActionView::Template::Error: undefined method `change_type_title' for nil:NilClass
  app/helpers/commits_helper.rb:150:in `cherry_pick_commit_link'
    tooltip = "Cherry-pick this #{commit.change_type_title} in a new merge request"
  app/views/projects/merge_requests/widget/_merged_buttons.haml:12:in `_app_views_projects_merge_requests_widget__merged_buttons_haml__3016672559654531416_54566540'
    = cherry_pick_commit_link(@merge_request.merge_commit, namespace_project_merge_request_path(@project.namespace, @project, @merge_request), btn_class: 'sm')
  app/views/projects/merge_requests/widget/_merged.html.haml:22:in `_app_views_projects_merge_requests_widget__merged_html_haml___1370597251318489830_55725220'
    = render 'projects/merge_requests/widget/merged_buttons', source_branch_exists: true
  app/views/projects/merge_requests/widget/_show.html.haml:4:in `_app_views_projects_merge_requests_widget__show_html_haml___2806373217290547563_55888060'
    = render 'projects/merge_requests/widget/merged'
  app/views/projects/merge_requests/_show.html.haml:40:in `_app_views_projects_merge_requests__show_html_haml__1045278443303219304_58187380'
    = render "projects/merge_requests/widget/show.html.haml"
...
(192 additional frame(s) were not displayed)

cc @DouweM @pmq20

Milestone changed to 8.7

Sorry, this is on me. It seems that https://gitlab.com/gitlab-org/gitlab-ce/commit/d00e5455 has already fixed this.

@DouweM Could you double check if this is now fixed on GitLab.com?

Milestone changed to 8.8

@yorickpeterse Verified, this MR would've been broken otherwise: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2

Status changed to closed