Replace Devise Async with Devise's implementation of async emails
Devise can integrate with ActiveJob with a bit of configuration, no external gem dependency needed. And it works with Devise 3.x!
Devise Async hasn't been updated since July 2015 and doesn't support the newly-released Devise 4 which will be necessary for Rails 5 (#14286 (moved)).
This is the commit that adds devise-async and it seems that it mostly hasn't been updated since, seeing as we're still on ~> 0.9.0.
I don't see any downsides to this change, any objections?
cc: @dzaporozhets
Activity
Apparently this was already sort of done in https://gitlab.com/gitlab-org/gitlab-ce/commit/e6dadea3891358ac7ed34dbb31eac403c193fcdc
So theoretically if we just remove devise async entirely it'll "just work".
mentioned in merge request !3902 (merged)
Milestone changed to 8.8
Status changed to closed by commit 1cc614f2
mentioned in commit 1cc614f2
mentioned in commit 88e4802d