update from 7.10.1 to 7.10.2 fails with "Mysql2::Error: Duplicate entry 'css' for key 'index_tags_on_name'"

i guess the main problem here comes from adding a unique index on tags.name: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/db/migrate/20150425164648_add_missing_unique_indices.acts_as_taggable_on_engine.rb#L4

in our tags table we have two CSS tags already, one upper, one lower case:

+----+----------------------+
| id | name                 |
+----+----------------------+
| 43 | css                  |
| 51 | CSS                  |
+----+----------------------+

the collation is still utf8_unicode_ci:

mysql> show create table tags ;
+-------+----------------------------------------------------------------------+
| Table | Create Table                                                         |
+-------+----------------------------------------------------------------------+
| tags  | CREATE TABLE `tags` (
  `id` int(11) NOT NULL AUTO_INCREMENT,
  `name` varchar(255) COLLATE utf8_unicode_ci DEFAULT NULL,
  PRIMARY KEY (`id`)
) ENGINE=InnoDB AUTO_INCREMENT=63 DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci |
+-------+----------------------------------------------------------------------+
1 row in set (0.00 sec)

is it possible that the order of DB migrations is wrong? https://gitlab.com/gitlab-org/gitlab-ce/blob/master/db/migrate/20150425164651_change_collation_for_tag_names.acts_as_taggable_on_engine.rb would change the collation to binary which is case sensitive and wouldn't cause this problem?

so for now as a workaround i manually applied the migrations in this order to get our gitlab in a more consistent state again:

was this the correct approach?

We're working on a patch for this.

@joernhees not sure, cc @vsizov @marin

Also mentioned in https://github.com/gitlabhq/gitlabhq/issues/9255

fixed here https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/623

Milestone changed to 7.11

Reassigned to @vsizov

Status changed to closed

Sorry for the migration issues. I think the workaround is sound. I think the acts_as_taggable module used to downcase all the tags (https://github.com/mbleigh/acts-as-taggable-on/issues/354), so the utf8_unicode_ci collation was fine for a while. Later on, it was switched to store the strings as-is.

It looks like that migration was added for another bug relating to UTF-8 errors, but it should be done before before the other migrations.

mentioned in merge request !625 (merged)

MySQL users also need this: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/625

mentioned in merge request !14785

update from 7.10.1 to 7.10.2 fails with "Mysql2::Error: Duplicate entry 'css' for key 'index_tags_on_name'"

Designs

Child items ...

Activity

Admin message

Admin message

update from 7.10.1 to 7.10.2 fails with "Mysql2::Error: Duplicate entry 'css' for key 'index_tags_on_name'"

Activity