For Oauth Registered Users (without password) when creating a password for the first time : second view ask for the current password (if password format is not vaild)

How to reproduce :

• Sign up with google (or other omniauth service)
• Go to profile settings > Password ( https://gitlab.com/profile/password/edit ) It is asked for : New password Password confirmation
• Enter a 6 length string for example : abcde / abcde in New password / Password confirmation and save
• It is now asked for the current password, and you can't go further.. : Current password New password Password confirmation

Thank you, regards

I see the version used is GitLab 7.11.1 6584346b

In the first view, the comment is Set your password. In the second one : Change your password or recover your current one.

In the controler, I guess the variable password_automatically_set has prematurely been updated.

gitlab-ce/app/views/profiles/passwords/edit.html.haml :

%h3.page-title Password Settings
%p.light
  - if @user.password_automatically_set?
    Set your password.
  - else
    Change your password or recover your current one.

The controller : https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/controllers/profiles/passwords_controller.rb

Added reproduced on GitLab.com label

@ainslie-dejour it would be great if could create a MR for this, considering you're already looking into the code.

Is this still valid for GitLab 7.14?

Milestone removed

Yes, ok, I was not very familiar with MR, but I can try that a bit later. I reproduced this on gitlab.com 3 month ago. I don't know what version it was.

@ainslie-dejour Do you know if this is still an issue?

@markglenfletcher Should this be closed/awaiting feedback as it deals with version 7 of GitLab?

added ~480950 ~65372 oauth labels

Closing this issue down in accordance with our Issue Triage Policies. Please reopen the issue if the you feel that the issue is still relevant. Thanks!

closed

mentioned in merge request !14785