ActionView::Template::Error: PG::GroupingError: ERROR: column "milestones.due_date" must appear ...

https://sentry.gitlap.com/gitlab/gitlabcom/issues/4462/

PG::GroupingError: ERROR:  column "milestones.due_date" must appear in the GROUP BY clause or be used in an aggregate function
LINE 1: ...HAVING count(distinct labels.title) = 2  ORDER BY milestones...
                                                             ^

  app/views/projects/issues/_issues.html.haml:2:in `_app_views_projects_issues__issues_html_haml__64912156108089974_48034320'
    = render @issues
  app/views/projects/issues/index.html.haml:25:in `_app_views_projects_issues_index_html_haml___1265384176385586197_70316925100340'
    = render "issues"
  app/controllers/projects/issues_controller.rb:38:in `index'
    respond_to do |format|
  lib/gitlab/metrics/rack_middleware.rb:17:in `block in call'
    retval = trans.run { @app.call(env) }
  lib/gitlab/metrics/transaction.rb:45:in `run'
    yield
...
(166 additional frame(s) were not displayed)

ActiveRecord::StatementInvalid: PG::GroupingError: ERROR:  column "milestones.due_date" must appear in the GROUP BY clause or be used in an aggregate function
LINE 1: ...HAVING count(distinct labels.title) = 2  ORDER BY milestones...
                                                             ^
: SELECT  "issues".* FROM "issues" INNER JOIN "label_links" ON "label_links"."target_id" = "issues"."id" AND "label_links"."target_type" = $1 INNER JOIN "labels" ON "labels"."id" = "label_links"."label_id" INNER JOIN "milestones" ON "milestones"."id" = "issues"."milestone_id" WHERE "issues"."deleted_at" IS NULL AND "issues"."confidential" = $2 AND ("issues"."state" IN ('opened','reopened')) AND "issues"."project_id" = 13083 AND "labels"."title" IN ('Merge Requests', 'Release') AND "labels"."project_id" = 13083 GROUP BY issues.id HAVING count(distinct labels.title) = 2  ORDER BY milestones.due_date ASC, milestones.id ASC LIMIT 20 OFFSET 0
  app/views/projects/issues/_issues.html.haml:2:in `_app_views_projects_issues__issues_html_haml__64912156108089974_48034320'
    = render @issues
  app/views/projects/issues/index.html.haml:25:in `_app_views_projects_issues_index_html_haml___1265384176385586197_70316925100340'
    = render "issues"
  app/controllers/projects/issues_controller.rb:38:in `index'
    respond_to do |format|
  lib/gitlab/metrics/rack_middleware.rb:17:in `block in call'
    retval = trans.run { @app.call(env) }
  lib/gitlab/metrics/transaction.rb:45:in `run'
    yield
...
(166 additional frame(s) were not displayed)

ActionView::Template::Error: PG::GroupingError: ERROR:  column "milestones.due_date" must appear in the GROUP BY clause or be used in an aggregate function
LINE 1: ...HAVING count(distinct labels.title) = 2  ORDER BY milestones...
                                                             ^
: SELECT  "issues".* FROM "issues" INNER JOIN "label_links" ON "label_links"."target_id" = "issues"."id" AND "label_links"."target_type" = $1 INNER JOIN "labels" ON "labels"."id" = "label_links"."label_id" INNER JOIN "milestones" ON "milestones"."id" = "issues"."milestone_id" WHERE "issues"."deleted_at" IS NULL AND "issues"."confidential" = $2 AND ("issues"."state" IN ('opened','reopened')) AND "issues"."project_id" = 13083 AND "labels"."title" IN ('Merge Requests', 'Release') AND "labels"."project_id" = 13083 GROUP BY issues.id HAVING count(distinct labels.title) = 2  ORDER BY milestones.due_date ASC, milestones.id ASC LIMIT 20 OFFSET 0
  app/views/projects/issues/_issues.html.haml:2:in `_app_views_projects_issues__issues_html_haml__64912156108089974_48034320'
    = render @issues
  app/views/projects/issues/index.html.haml:25:in `_app_views_projects_issues_index_html_haml___1265384176385586197_70316925100340'
    = render "issues"
  app/controllers/projects/issues_controller.rb:38:in `index'
    respond_to do |format|
  lib/gitlab/metrics/rack_middleware.rb:17:in `block in call'
    retval = trans.run { @app.call(env) }
  lib/gitlab/metrics/transaction.rb:45:in `run'
    yield
...
(166 additional frame(s) were not displayed)

Here is a spec example to reproduce the failure locally (it happens only with Postgres, not MySQL):

# spec/features/merge_requests/user_lists_merge_requests_spec.rb
      context 'filter on two labels' do
         let(:label) { create(:label, project: project) }
         let(:label2) { create(:label, project: project) }
         before do
           create(:label_link, label: label, target: fix)
           create(:label_link, label: label2, target: fix)
         end
 
         it 'sorts by due soon' do
           visit namespace_project_merge_requests_path(project.namespace, project,
             label_name: [label.name, label2.name],
             sort: sort_value_due_date_soon)
 
           expect(first_merge_request).to include('fix')
         end
 
         context 'filter on assignee' do
           it 'sorts by due soon' do
             visit namespace_project_merge_requests_path(project.namespace, project,
               label_name: [label.name, label2.name],
               assignee_id: user2.id,
               sort: sort_value_due_date_soon)
 
             expect(first_merge_request).to include('fix')
           end
 
           it 'sorts by recently due milestone' do
             visit namespace_project_merge_requests_path(project.namespace, project,
               label_name: [label.name, label2.name],
               assignee_id: user2.id,
               sort: sort_value_milestone_soon)
 
             expect(first_merge_request).to include('fix')
           end
         end

Milestone changed to 8.7

Added regression reproduced on GitLab.com labels

mentioned in issue #14939 (closed)

mentioned in merge request !3886 (merged)

mentioned in issue #15557 (closed)

this commit might be related? https://gitlab.com/gitlab-org/gitlab-ce/commit/4ab49fab94284f3f7e3804309ba8825ed28fc24c (Changelog Entry)

@benalbrecht I don't think so, 4ab49fab was merged way later than when we experienced this error.

Closing in favor of #15557 (closed).

Status changed to closed