Add a message to the 404 page to indicate it may be a permission issue

Zendesk: https://gitlab.zendesk.com/agent/tickets/15943

We display a 404 page when users don't have permission to a project to avoid leaking information about projects/groups. It could be advantageous to add an ambiguous message to the 404 page saying 'it either doesn't exist or you don't have permission to view the resource'. This would be similar to what we do for password reset: 'If your account exists in our system, you will receive a message'. We are descriptive but avoid disclosing whether the account exists.

cc/ @JobV @DouweM What do you think?

@dblessing Good idea

mentioned in merge request !4174 (closed)

Reassigned to @lbennett

Assignee removed

any news on this ?

@lbennett Can we open this for a Community Contribution to add?

We can discuss on the content of the display message here beforehand, but it would make a nice first contribution for someone Thanks!

added feature proposal ~1208338 labels

@markglenfletcher Sounds like a great idea. :)

added Community Contribution label

Looks like we mean Accepting Merge Requests? Since I don't see a contribution yet

added Accepting Merge Requests and removed Community Contribution labels

Thanks.

What should we use for this ambiguous message? Along the same lines of the password reset email we could use:

"The resource that you are attempting to access does not exist or you don't have the necessary permissions to view it"

@markglenfletcher is this how it should be?

@brancho Yes. Let's go with that text. Would you like to create a Merge Request to add it?

That probably won't make any difference to me though. Since I already know what 404 means, so I would only read the heading but only because the words are large and I would see it anyway. Yet, I would still assume it's missing, not because I might not able to read it.

I suggest we also change the heading. Maybe something like:

404

This page could not be found or you don't have the permission.

mentioned in merge request !13982 (merged)

@godfat I changed the title, added the message and created a merge request @markglenfletcher

assigned to @brancho

added Community Contribution and removed Accepting Merge Requests labels

changed milestone to %10.0

moved to gitlab#4869

Hey!

GitLab is moving all development for both GitLab Community Edition and Enterprise Edition into a single codebase. The current gitlab-ce repository will become a read-only mirror, without any proprietary code. All development is moved to the current gitlab-ee repository, which we will rename to just gitlab in the coming weeks. As part of this migration, issues will be moved to the current gitlab-ee project.

If you have any questions about all of this, please ask them in our dedicated FAQ issue.

https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

You can also find more information here:

• https://gitlab.com/gitlab-org/gitlab-ee/issues/13304
• https://about.gitlab.com/2019/08/23/a-single-codebase-for-gitlab-community-and-enterprise-edition/

Frequently Asked Questions

For an up to date list of questions and answers, please take a look at https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

What will we do with the repository names?

https://gitlab.com/gitlab-org/gitlab-ee/ will become https://gitlab.com/gitlab-org/gitlab, and https://gitlab.com/gitlab-org/gitlab-ce will become https://gitlab.com/gitlab-org/gitlab-foss.

Why rename gitlab-ce to gitlab-foss?

Using "gitlab" and "gitlab-ce" would be confusing, so we decided to rename gitlab-ce to gitlab-foss to make the purpose of this FOSS repository more clear

I created a merge requests for CE, and this got closed. What do I need to do?

You will need to create a merge request at https://gitlab.com/gitlab-org/gitlab-ee/. This link will eventually redirect to https://gitlab.com/gitlab-org/gitlab.

How does the licensing work in this new setup?

Everything in the ee/ directory is proprietary. Everything else is free and open source software. If your merge request does not change anything in the ee/ directory, the process of contributing changes is the same as when using the gitlab-ce repository.

Will you accept merge requests on the gitlab-ce/gitlab-foss project after it has been renamed?

No. Merge requests submitted to this project will be closed automatically.

Will I still be able to view old issues and merge requests in gitlab-ce/gitlab-foss?

Yes.

How will this affect users of GitLab CE using Omnibus?

No changes will be necessary, as the packages built remain the same.

How will this affect users of GitLab CE that build from source?

Once the project has been renamed, you will need to change your Git remotes to use this new URL. GitLab will take care of redirecting Git operations so there is no hard deadline, but we recommend doing this as soon as the projects have been renamed.

Where can I see a timeline of the remaining steps?

https://gitlab.com/gitlab-org/gitlab-ee/issues/13304

Will community contributions submitted to the new "gitlab" repository be available in the new gitlab-foss repository?

Yes, these changes will be synced to gitlab-foss automatically, several times per day.

locked this issue