Guest gets 404 error when tries to see a commit from a issue

Summary

Guest gets 404 error when tries to see a commit, which closed an issue ticket.

This is reproduced on gitlab.com

Steps to reproduce

• Create an issue ticket. (#1 (closed))
• Close it via commit with message “fix #1 (closed)”.
• Log as member with guest rights.
• Look the issue ticket. Click on the commit.
• 404 appears

Expected behavior

Well, the absolute marvellous solution would be to let the guest member see at least the message from the ticket. It’s very convenient to just close the issue by commit and not to go to issue page and copy paste the comment from commit message to the issue ticket comment.

The point of the guest right is to create issues, not sneaking around the code :) but what’s the point if the guest can’t read the explanation how was the ticket closed?

The other solution is hide the commit link, but then the programmer has to copy every message from commit to the issue ticket. Please don’t force us :).

Added ~14281 label

In my opinion, the solution is to hide Activity Page for guest users

mentioned in issue #13325 (closed)

I’d avoid this solution if possible. Why to disable such an important feature to the whole group of people?

The answer to this problem is really clear and simple:

If we intend "Guest Users" to be our clients companies, due to obvious reasons Guest users should not be aware of the Activity list in a development process. The explanation for how the ticket was closed should be in the ticket itself (like other bug trackers i.e. Mantis, Redmine, ..). Developers of course shouldn't copy every message from commit to the issue ticket but using a specific markdown code for the ticket (or similar solutions) gitlab should link a specific commit to the ticket... this is a developer choice and only this messages should be visible. I think it's ok to have a "Guest" user like the one you've created but at this point there should be a specific ACL for this kind of clients.. a "Ticket Only" user

Or maybe gitlab could copy the message from the commit, if the commit fixes the issue.

Do you think we'll see this kind of user in the near future? I think a lot of companies and users are just waiting to find something exactly like gitlab.com but with more ACL controls

I’m afraid I don’t know where you’re heading with your post. What kind of users do you think of?

Added ~874211 label

moved to gitlab#4988

Hey!

GitLab is moving all development for both GitLab Community Edition and Enterprise Edition into a single codebase. The current gitlab-ce repository will become a read-only mirror, without any proprietary code. All development is moved to the current gitlab-ee repository, which we will rename to just gitlab in the coming weeks. As part of this migration, issues will be moved to the current gitlab-ee project.

If you have any questions about all of this, please ask them in our dedicated FAQ issue.

https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

You can also find more information here:

• https://gitlab.com/gitlab-org/gitlab-ee/issues/13304
• https://about.gitlab.com/2019/08/23/a-single-codebase-for-gitlab-community-and-enterprise-edition/

Frequently Asked Questions

For an up to date list of questions and answers, please take a look at https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

What will we do with the repository names?

https://gitlab.com/gitlab-org/gitlab-ee/ will become https://gitlab.com/gitlab-org/gitlab, and https://gitlab.com/gitlab-org/gitlab-ce will become https://gitlab.com/gitlab-org/gitlab-foss.

Why rename gitlab-ce to gitlab-foss?

Using "gitlab" and "gitlab-ce" would be confusing, so we decided to rename gitlab-ce to gitlab-foss to make the purpose of this FOSS repository more clear

I created a merge requests for CE, and this got closed. What do I need to do?

You will need to create a merge request at https://gitlab.com/gitlab-org/gitlab-ee/. This link will eventually redirect to https://gitlab.com/gitlab-org/gitlab.

How does the licensing work in this new setup?

Everything in the ee/ directory is proprietary. Everything else is free and open source software. If your merge request does not change anything in the ee/ directory, the process of contributing changes is the same as when using the gitlab-ce repository.

Will you accept merge requests on the gitlab-ce/gitlab-foss project after it has been renamed?

No. Merge requests submitted to this project will be closed automatically.

Will I still be able to view old issues and merge requests in gitlab-ce/gitlab-foss?

Yes.

How will this affect users of GitLab CE using Omnibus?

No changes will be necessary, as the packages built remain the same.

How will this affect users of GitLab CE that build from source?

Once the project has been renamed, you will need to change your Git remotes to use this new URL. GitLab will take care of redirecting Git operations so there is no hard deadline, but we recommend doing this as soon as the projects have been renamed.

Where can I see a timeline of the remaining steps?

https://gitlab.com/gitlab-org/gitlab-ee/issues/13304

Will community contributions submitted to the new "gitlab" repository be available in the new gitlab-foss repository?

Yes, these changes will be synced to gitlab-foss automatically, several times per day.

locked this issue