/etc/init.d/gitlab needs to source /etc/default/gitlab earlier

https://gitlab.com/gitlab-org/gitlab-ce/blob/master/lib/support/init.d/gitlab#L39

Since the default file redefines the gitlab root path, I think it needs to be sourced before the pid_path definition (line 33).

Shouldn't this file overwrite the default configs of the GitLab configs?

Point taken. Maybe I'm thinking about the purpose of the default file wrongly. I was assuming that

1. users probably only ever change the username and parent directory, since everything else is relative to that

2. the usefulness of the default script is that it means the init doesn't need to be modified with every upgrade. If an upgrade were to add a new secondary configuration item relative to $app_root the default script would need to be modified which would sort of defeat the purpose. Additionally, needed modifications to existing secondary configuration would be wrongly overridden by the default file.

Seems that this isn't a bug, but a misunderstanding.
I'll close this issue for now. If you still think this should be changed, please make a suggestion in the feedback forum: http://feedback.gitlab.com/forums/176466-general

#community-weekend-feb-2015

Status changed to closed

mentioned in commit 9d2840fb

Mentioned in commit 9d2840fb

mentioned in merge request !14785