Merge When Build Succeeds Button - Wrong Colors

Here's the DOM for that that Chrome shows me:

<div class="accept-action">
<span class="btn-group">
<button name="button" type="submit" class="btn js-merge-button merge_when_build_succeeds btn-warning">Merge When Build Succeeds
</button><button name="button" type="submit" class="btn btn-success dropdown-toggle" data-toggle="dropdown"><span class="caret"></span>
<span class="sr-only">
Select Merge Moment
</span>
</button><ul class="js-merge-dropdown dropdown-menu dropdown-menu-right" role="menu">
<li>
<a class="merge_when_build_succeeds" href="#"><i class="fa fa-check fa-fw"></i>
Merge When Build Succeeds
</a></li>
<li>
<a class="accept_merge_request" href="#"><i class="fa fa-warning fa-fw"></i>
Merge Immediately
</a></li>
</ul>
</span>
</div>

So the "dropdown-toggle" has "btn-success", rather than "btn-warning".

I'm seeing this in 8.8.2, and I think this was not the case in 8.8.0...

Added frontend label

Thanks for the report @pioto! /cc @iamphill

Added regression reproduced on GitLab.com labels

Milestone changed to %8.8

!4211 (merged) didn't fix this issue, or maybe it introduced it?

mentioned in issue #17519 (closed)

!4211 (merged) should fix this & I think it should be in the next patch @rymai

@iamphill Hmm, unfortunately I don't think so, !4211 (merged) was already shipped in 8.8.2: https://gitlab.com/gitlab-org/gitlab-ce/commit/d5640394b53be350d4210aead9f3556d8350aff5 / https://about.gitlab.com/2016/05/25/gitlab-8-dot-8-dot-2-released/

@rymai oh wow I thought it wasnt live yet! I'll have a look

So I actually think !4287 (merged) fixed it. Looking at https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4287/diffs#5492807eeff7d8f64b722d397811464b1becdf97_130_130

Ok, cool, we'll see then! ;)

Status changed to closed

Confirmed this is fixed in 8.8.3.

@rspeicher Awesome, thanks!