Merge request 'Builds' section should show all builds for the latest commit

Currently, Builds section of merge request shows only the build job triggered for the branch ref. Consider that branches are excluded from build, but tags are built and the branch we are going to merge is tagged. Currently, builds section of merge request shows 'skipped', since the build of branch itself is skipped. But since the last commit of the branch is tagged, the branch is actually built and merge request should show the result of build of the tag.

In other words, Builds section of a merge request should show ALL builds of the head of the branch rather than only the build of its ref.

mentioned in issue #18681 (closed)

Interesting: tag is newer tied to branch, this is only annotation of revision.

So basically in context of Merge Request we are showing what we should show: the builds for specific branch, tag are external concept here.

Added ~19173 label

I hope this is solved by Pipelines for merge requests: #18681 (closed)

You show 'builds for the last commit of the branch'. What if the commit is built, but because of a tag (e.g. assume 'ready_for_merge' tag)? BTW, IMHO, all builds of the last commit are relevant.

Can you confirm if this was solved by https://gitlab.com/gitlab-org/gitlab-ce/issues/18681?

I'll re-confirm tomorrow, but IIRC, no, it is not fixed: no pipeline tab is shown for such a project (because it is considered 'skipped'). But I'll check again tomorrow.

Changed title: Merge request 'Builds' section should show all builds of the pipeline → Merge request 'Builds' section should show all builds for the latest commit

The issue still exists. The pipelines view does show pipelines for the branch, but it doesn't include builds triggered by the tags on the same commits.

So, what do I expect? I think if we have a commit in the HEAD of a branch, e.g. 4a39aa2e, then ALL builds for this commit should be considered to assess the CI status of the branch, including the builds which have happened because of tagging.

Example of when this is useful: there is a project in which builds are triggered only by tags: a regular commit is simply skipped. a commit is built only when it is tagged. Now, a branch is created and is ready to be merged. HEAD of the branch is tagged, which will trigger a build on it. Currently, this build is completely ignored in the merge request view, but we expected it to appear, since this is a build on the HEAD of the branch. If the tag is built successfully, we can say that the branch is OK with this regard, so I think it is rational to include this build among builds of the branch.

I'm not saying that you should links tags with branches. Tags are not important here. I just expect you to include ALL builds for a specific commit, regardless of where it resides (even if a single commit exists in two separate branches, I think it is rational to include the build status of that commit in the other branch too, since it is exactly the same commit).

moved to gitlab#5148

Hey!

GitLab is moving all development for both GitLab Community Edition and Enterprise Edition into a single codebase. The current gitlab-ce repository will become a read-only mirror, without any proprietary code. All development is moved to the current gitlab-ee repository, which we will rename to just gitlab in the coming weeks. As part of this migration, issues will be moved to the current gitlab-ee project.

If you have any questions about all of this, please ask them in our dedicated FAQ issue.

https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

You can also find more information here:

• https://gitlab.com/gitlab-org/gitlab-ee/issues/13304
• https://about.gitlab.com/2019/08/23/a-single-codebase-for-gitlab-community-and-enterprise-edition/

Frequently Asked Questions

For an up to date list of questions and answers, please take a look at https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

What will we do with the repository names?

https://gitlab.com/gitlab-org/gitlab-ee/ will become https://gitlab.com/gitlab-org/gitlab, and https://gitlab.com/gitlab-org/gitlab-ce will become https://gitlab.com/gitlab-org/gitlab-foss.

Why rename gitlab-ce to gitlab-foss?

Using "gitlab" and "gitlab-ce" would be confusing, so we decided to rename gitlab-ce to gitlab-foss to make the purpose of this FOSS repository more clear

I created a merge requests for CE, and this got closed. What do I need to do?

You will need to create a merge request at https://gitlab.com/gitlab-org/gitlab-ee/. This link will eventually redirect to https://gitlab.com/gitlab-org/gitlab.

How does the licensing work in this new setup?

Everything in the ee/ directory is proprietary. Everything else is free and open source software. If your merge request does not change anything in the ee/ directory, the process of contributing changes is the same as when using the gitlab-ce repository.

Will you accept merge requests on the gitlab-ce/gitlab-foss project after it has been renamed?

No. Merge requests submitted to this project will be closed automatically.

Will I still be able to view old issues and merge requests in gitlab-ce/gitlab-foss?

Yes.

How will this affect users of GitLab CE using Omnibus?

No changes will be necessary, as the packages built remain the same.

How will this affect users of GitLab CE that build from source?

Once the project has been renamed, you will need to change your Git remotes to use this new URL. GitLab will take care of redirecting Git operations so there is no hard deadline, but we recommend doing this as soon as the projects have been renamed.

Where can I see a timeline of the remaining steps?

https://gitlab.com/gitlab-org/gitlab-ee/issues/13304

Will community contributions submitted to the new "gitlab" repository be available in the new gitlab-foss repository?

Yes, these changes will be synced to gitlab-foss automatically, several times per day.

locked this issue