GitLab push notification email formatting about 6 times too tall (5 blank lines between each diff line)
We are generating push notification emails in gitlab CE omnibus 8.9 on ubuntu 14.04 lts. The emails that are generated are readable except for the diff area which is unreadable, due to a very large number of empty lines in between the real content lines:
Activity
This formatting problem reproduces
on gmail, andin Outlook, I am willing to investigate this and do something to build a reproducible test case (perhaps push a repo that has this problem up to a public gitlab area).Edited by username-removed-510609Previous comment is wrong. Issue reproduces in Outlook but not in Google Mail.
This may be a non-compliance issue inside Outlook or even Office 365 (given how much of a mess microsoft's outlook desktop client's integration with office 365's exchange-server-like elements) itself.
If I forward the email after it's been received by Outlook to GMail, then the issue reproduces. However I can't say for sure that the html-email has not been tampered with by Outlook itself or Office 365's servers.
Edited by username-removed-510609Added ~12980 emails labels
Added notifications label
This duplicates my #19613 (closed), which itself duplicates #17624 (closed).
If someone could direct me to the general area the relevant code lives, I might be able to take a look at this. It's causing a significant headache in my office, which lives and breathes commit emails.
There appears to be extra crap at the end of each row that looks like this in the generated emails, three nonbreaking spaces each with their own paragraph tag and span, and each with its own single non breaking space content, per each
<td></td>:<p class=MsoNormal align=right style='text-align:right'><span style='font-size:10.0pt;font-family:"Courier New";mso-fareast-font-family: "Times New Roman";color:#333333'><o:p> </o:p></span></p> <p class=MsoNormal><span style='font-family:"Courier New";mso-fareast-font-family: "Times New Roman";color:#333333'><o:p> </o:p></span></p> <p class=MsoNormal><span style='font-family:"Courier New";mso-fareast-font-family: "Times New Roman";color:#333333'><o:p> </o:p></span></p>Edited by username-removed-510609
/cc: @iamphill, @smcgivern
Stan do you think this MR fixes this issue too? https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5588
-
@warren.postma It might. You could try testing on GitLab.com to see if the diffs generated look better.
Edited by Stan Hu The issue is still present on GitLab.com:
(generated from https://gitlab.com/hooksie/GitLab-Service-Email-Test)
Thanks @hooksie, that's really helpful!
I also created a PutsMail test, so we can just work with the HTML directly and see what the issue is: https://putsmail.com/tests/1f05d11a-4fb0-4e93-9b07-711f26198e33
@iamphill Googling shows me a lot of horrible things Outlook might do with table cell height and line heights in general, but I don't know which of them apply here
@smcgivern I'll have a look
I managed to get rid of the odd line height but it seems like outlook (outlook.com at least) is removing the spaces for some reason
https://putsmail.com/tests/ff9e7b4a-e8f1-4ddb-9c6b-70054c71055d
@iamphill I'll give it a go again when I get into my office (in an hour or two).
@hooksie that would be great, thank you!
Thanks @bkraul! What version of Outlook is that?
Office 2010 here, lgtm.
(Which makes senses, seeing how Outlook 2010 and 2013 use the same rendering engine.)
Edited by username-removed-262894Awesome stuff, I take it no-one objects if we don't do the extra work to support leading whitespace on Outlook.com? It's not a huge amount of work but it would make a template more complicated for relatively little gain. /cc @stanhu
I'm not an Outlook.com user, so I have no dog in that race. So no objection from me.
That said, if you're mean leading line whitespace, I would lightly caution against undervaluing that. For us Python devs, it might make a big difference in understanding the diff. (Or I might not understand what leading whitespace you are referring to.)
Edited by username-removed-262894-
@smcgivern I've actually seen Gmail occasionally remove the leading whitespace too: https://gitlab.com/gitlab-org/gitlab-ee/issues/485
I'm not sure if this is the same problem, and I can't consistently reproduce the problem.
@stanhu I can consistently reproduce it in Outlook.com. Adding
would also solve it-
Attached is an HTML that displays no spaces for me on Gmail. This was sent April 13, 2016, so this could just be outdated:
Thanks! That's not the problem with whitespace being collapsed that we see on Outlook.com, there's just no whitespace in the HTML (!), so I'm happy calling that a separate thing.
<td style="background:#eaffea;border:none;color:#333;display:block;font-family:'Menlo','Liberation Mono','Consolas','DejaVu Sans Mono','Ubuntu Mono','Courier New','andale mono','lucida console',monospace;font-size:13px;line-height:1.5;margin:0;padding:0 0.5em;white-space:pre-wrap" bgcolor="#eaffea">+<span> <span style="color:teal">@merge_requests</span> <span style="font-weight:bold">=</span> <span style="color:teal">@issue</span><span>.</span><span style="color:#900;font-weight:bold">referenced_merge_<wbr>requests</span><span>(</span><span style="color:#333">current_user</span><span>)</span></span> </td>@iamphill what was the change we needed? I can apply it if you're busy.
@smcgivern I think the best solution - if possible - is to change whitespaces into
. If not, i think wrapping the line content inpretag worked aswell.mentioned in merge request !5843 (merged)
@hooksie thanks for the reminder, I was away last week. https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5843 created!
Status changed to closed by merge request !5843 (merged)
mentioned in commit ab5cc542
Mentioned in commit pfjason/gitlab-ce@ab5cc542
mentioned in merge request !14785
