Data from imports being preserved after the project import has finished

As explained here - https://gitlab.com/gitlab-com/infrastructure/issues/177#note_12865110

Some of the import_data seems to remain even after a successful import. This should get removed straight after...

mentioned in issue gitlab-com/infrastructure#177 (closed)

mentioned in issue #19486 (closed)

@jameslopez This seems to be the number one problem this week with customers. Do we have a solution for this?

@stanhu I haven't looked at it yet but I can do so after finishing off with another regression.

I thought it wasn't that important - there shouldn't be any error showed to the user AFAIK?

also, do we want this for 8.9.X ?

@jameslopez Yes, I think a 8.9 fix would be good since many customers are attempting to upgrade and hitting this hard.

Milestone changed to %8.9

cool, I will look into it soon, probably on Monday

Reassigned to @jameslopez

Different issues seem to occur here. Let's try to enumerate them. In all of them, the import_data is still there.

1. Bitbucket or GitHub import, status finished but import_data still there.
2. Import by URL, with connectivity error - but status is finished
3. Import by URL, status finished, all other relevant fields are either nil or empty.
4. status is none, all other relevant fields are either nil or empty.

I assume this should all be fixed by the refactor that will be done in 8.10 anyway - https://gitlab.com/gitlab-org/gitlab-ce/issues/18235

I'm gonna spend some time trying to replicate the most obvious locally and submit a fix :)

mentioned in merge request !5206 (merged)

mentioned in issue #18343 (closed)

Status changed to closed by merge request !5206 (merged)

Added regression label