Export - import of a repo, hooks failling (Workaround found, but need to be fixed)

So I've checked it twice, and there is actually a bug. The hook system isn't working properly on an imported repo.

1. create a repo MyRepoA and add a readme

2. create an issue and modify the readme with "fix #1 (closed)" in the commit message

   -> the issue is closed

3. export myRepoA from edit project->export

4. import it as MyRepoB, create an issue and try to close it by adding "fix #2 (closed)" to your commit message.

   -> the issue isn't closed

Any ideas?

If we add a gitlab-ci.yml and a worker to the imported project, nothing is called. It seems that something is blocking the hooks on an imported project.

I am a bit alone on my issue, but I'm continuing my investigations, it looks like the hooks folder of the imported repo (B) is empty (full of samples), so the hooks created by gitlab on the exported repo (A) aren't recreated or copied. Can the correction be done easily, first with a workaround (for already imported projects) and then with a fix in gitlab importer?

Workaround

Hi, so I've found the issue and I have a workaround. So first of all, go in your /var/opt/gitlab/git-data/repositories/{"root","or an other user"} to find the .git folder of your imported repo. For the last example it would be :

# cd /var/opt/gitlab/git-data/repositories/root/MyRepoB.git/

Form there, list the files :

# ls -alh
total 44K
drwxr-xr-x  7 git git 4.0K Jul  6 16:37 .
drwxrwx---  9 git git 4.0K Jul  6 17:23 ..
drwxr-xr-x  2 git git 4.0K Jul  6 16:37 branches
-rw-r--r--  1 git git  179 Jul  6 16:37 config
-rw-r--r--  1 git git   73 Jul  6 16:37 description
-rw-r--r--  1 git git   23 Jul  6 16:37 HEAD
drwxr-xr-x  2 git git 4.0K Jul  7 10:46 hooks
drwxr-xr-x  2 git git 4.0K Jul  6 16:37 info
drwxr-xr-x 16 git git 4.0K Jul  7 10:40 objects
-rw-r--r--  1 git git   98 Jul  6 16:37 packed-refs
drwxr-xr-x  5 git git 4.0K Jul  6 16:38 refs

Now remove your hooks directory (check that there is nothing important in it) and replace it by a symlink to the gitlab's hooks

# rm -R hooks/
# ln -s /opt/gitlab/embedded/service/gitlab-shell/hooks hooks
# ls -alh
total 40K
drwxr-xr-x  6 git  git  4.0K Jul  7 10:48 .
drwxrwx---  9 git  git  4.0K Jul  6 17:23 ..
drwxr-xr-x  2 git  git  4.0K Jul  6 16:37 branches
-rw-r--r--  1 git  git   179 Jul  6 16:37 config
-rw-r--r--  1 git  git    73 Jul  6 16:37 description
-rw-r--r--  1 git  git    23 Jul  6 16:37 HEAD
lrwxrwxrwx  1 root root   47 Jul  7 10:48 hooks -> /opt/gitlab/embedded/service/gitlab-shell/hooks
drwxr-xr-x  2 git  git  4.0K Jul  6 16:37 info
drwxr-xr-x 16 git  git  4.0K Jul  7 10:40 objects
-rw-r--r--  1 git  git    98 Jul  6 16:37 packed-refs
drwxr-xr-x  5 git  git  4.0K Jul  6 16:38 refs

The most important command in this was ln -s /opt/gitlab/embedded/service/gitlab-shell/hooks hooks. It recreates a hooks folder by linking to the gitlabs's one.

At this point we can clean up a bit by changing the owner back to git:

# chown -h git:git hooks
# ls -alh
total 40K
drwxr-xr-x  6 git git 4.0K Jul  7 10:48 .
drwxrwx---  9 git git 4.0K Jul  6 17:23 ..
drwxr-xr-x  2 git git 4.0K Jul  6 16:37 branches
-rw-r--r--  1 git git  179 Jul  6 16:37 config
-rw-r--r--  1 git git   73 Jul  6 16:37 description
-rw-r--r--  1 git git   23 Jul  6 16:37 HEAD
lrwxrwxrwx  1 git git   47 Jul  7 10:48 hooks -> /opt/gitlab/embedded/service/gitlab-shell/hooks
drwxr-xr-x  2 git git 4.0K Jul  6 16:37 info
drwxr-xr-x 17 git git 4.0K Jul  7 10:48 objects
-rw-r--r--  1 git git   98 Jul  6 16:37 packed-refs
drwxr-xr-x  5 git git 4.0K Jul  6 16:38 refs

We're done! Now the automatic issue closing feature and the continuous integration should work.

This needs to be corrected in the gitlab importation process. If you don't want to remove the hooks of the imported git, gitlab should display this kind of check box:

• Replace the hooks folder by the gitlab's one? Note that it is needed for features like continuous integration or automatic issue closing on commit

Can anyone (aware enough of gitlab and the importation process) send a pull request to correct this?

Note that I'm not agree on closing the issue now, as I just found a workaround.

Changed title: Export - import, hooks failling → Export - import of a repo, hooks failling (Workaround found, but need to be fixed)

Added import label

Added ~12980 label

thanks for reporting this @nesnes !

Reassigned to @jameslopez

mentioned in merge request !5549 (merged)

mentioned in issue #19582 (closed)

mentioned in issue #19938 (closed)

mentioned in issue #20105 (closed)

Status changed to closed by commit 6ad514d0

mentioned in commit 6ad514d0

mentioned in commit c004ed5f

Mentioned in commit pfjason/gitlab-ce@c004ed5f