Selected line creates invalid link
Description
When clicking on a line in the file browser, a link to that particular line is generated using Javascript. However, when clicking the link icon in the left gutter, an invalid link is generated.
- Open
https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG
- When hovering over a line on the left gutter, click on the appearing link icon
- Look the URL field of the browser and observer the wrong URL
Observed behaviour
GitLab generates an invalid link. Instead of appending the line number (e.g. L44
) the value undefined
is appended. This looks like the following:
https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG#Lundefined
Expected behaviour
GitLab generates a valid link to the selected line.
https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG#L44
Affected versions
This happens on gitlab.com. This might be related to some Javascript refactoring for the diffs. /cc @stanhu