`Invalid raw diff type: String` on old merge request
Zendesk issue: https://gitlab.zendesk.com/agent/tickets/33460
Customer reports that this old merge request (over 1 year old) now produces the 500 error below when trying to access. This is probably some edge case bug from a change in the way merge requests are handled now. @DouweM @rspeicher @stanhu Any ideas?
Started GET "/group/project/merge_requests/260" for 127.0.0.1 at 2016-08-09 11:23:07 -0700
Processing by Projects::MergeRequestsController#show as HTML
Parameters: {"namespace_id"=>"group", "project_id"=>"project", "id"=>"260"}
Completed 500 Internal Server Error in 526ms (ActiveRecord: 26.8ms)
ActionView::Template::Error (Invalid raw diff type: String):
60: %li.diffs-tab
61: = link_to diffs_namespace_project_merge_request_path(@project.namespace, @project, @merge_request), data: {target: 'div#diffs', action: 'diffs', toggle: 'tab'} do
62: Changes
63: %span.badge= @merge_request.diff_size
64:
65: .tab-content
66: #notes.notes.tab-pane.voting_notes
app/models/merge_request_diff.rb:34:in `size'
app/models/merge_request.rb:184:in `diff_size'
app/views/projects/merge_requests/_show.html.haml:63:in `block in_app_views_projects_merge_requests__show_html_haml__3465261509214418567_170052060'
app/views/projects/merge_requests/_show.html.haml:61:in `_app_views_projects_merge_requests__show_html_haml__3465261509214418567_170052060'
app/views/projects/merge_requests/show.html.haml:1:in `_app_views_projects_merge_requests_show_html_haml__221101912090092131_170074880'
app/controllers/projects/merge_requests_controller.rb:60:in `show'
lib/gitlab/middleware/go.rb:16:in `call'
lib/gitlab/middleware/readonly_geo.rb:29:in `call'