Allow specifying committers username/email via API

Summary

Per discussion in https://gitlab.com/gitlab-org/gitlab-ce/issues/20147, we'd like to implement the ability to specify a username/email when making commits thru the API.

feature proposal api

Possible Solution (needs work)

• Update the create, update, and delete requests in the Files API to accept optional params to specify the committers username/email
• How can we make those params usable in file services so it results in properly setting the commiter details in the repository model?
  • Note: we'd like to use our admin user's API token and specify these options to commit as different Gitlab users

Links

• Files API
• Files Services
• Repository Model
• Repository Files Doc

mentioned in issue #20147 (closed)

Added ~480950 ~13884 feature proposal labels

mentioned in merge request !5570 (closed)

Milestone changed to %Backlog

@DouweM or @rymai

Can either of you or someone else review this and see if my suggestion for the "possible solution" is headed in the right direction?

If so, I could get started on a MR unless someone else wants to take it on.

@dandunckelman The proposal sounds good to me. The repository commit methods would need an extra optional author keyword argument that would be used instead of user_to_committer(user). The params would need to be passed from the API, to the service, to the repository methods.

Thanks @DouweM. I'll have MR up soon.

mentioned in merge request !5822 (merged)

@DouweM MR is pretty complete (waiting for latest build to go thru...it should pass). I think it deserves a review at this point. Maybe you or @rymai could take that on?

Thanks

Reassigned to @dandunckelman

Status changed to closed by merge request !5822 (merged)

Mentioned in commit 16157bd0

mentioned in merge request !14785