Todos index is slow

Today's numbers:

The SQL queries seems to be the main issue, their graph is almost identical to the one above.

@ahmadsherif could you link at the right graph in performance.gitlab.net ?

@pcarranza Here you go http://performance.gitlab.net/dashboard/db/rails-controllers?panelId=3&fullscreen&var-action=Dashboard::TodosController%23index&var-database=Production&from=now%2Fd&to=now

thanks!

You are right, SQL timings suck

It seems that the bulk of query time is spent on joining user's todos with projects he can acccess, the latter is large set (195098 row in my case) since it includes public and internal projects. I modified the query manually to add a predicate like SELECT "todos"."project_id" FROM todos WHERE "todos"."user_id" = 1 AND "todos"."state" = 'done' to every UNIONed SELECT, now it finishes in ~30 ms.

I'll try to code that tomorrow.

Also I think #20498 (moved) could benefit from such modification somehow.

Great @ahmadsherif, thanks!

mentioned in commit 53797b90

mentioned in merge request !5791 (merged)

mentioned in commit 735e45c4

mentioned in commit d13c36f7

Status changed to closed by merge request !5791 (merged)

Mentioned in commit d13c36f7