Inconsistency: Issue Weight filter dropdown/title should update when active

At this moment when filtering issues with a selected weight, the button is not updated.

compared against the other filter dropdowns:

see gif:

probably want it to look like:

mentioned in issue #19342 (moved)

@dimitrieh wouldn't it be more consistent to make the dropdown label the same as the selected value?

Examples:

@ClemMakesApps Yes it would actually, please keep it at "1". The only thing why I considered it, is that I think the dropdown buttons lose informational value, when a value is active.. you cannot see, that it actually represents weight, when it only displays: "1". This should be solved in a different way ;) Will get back on this.

I agree with your reasoning 👍 Hopefully we can get a new improved design that improves the usability of the issue filters 😄

mentioned in issue #21783 (closed)

@ClemMakesApps would you be willing to fix this for now? ;) filters and search will get a big redesign in the future, talk along here: https://gitlab.com/gitlab-org/gitlab-ce/issues/21747

Changed title: Issue Weight filter dropdown/title should update when active → Inconsistency: Issue Weight filter dropdown/title should update when active

I'll try to look into this one. Implementing it isn't difficult, it's getting the unit tests to work that's tough 😞 Still trying to figure out when to use rspec and when to use jasmine tests. I am more familiar with jasmine tests but rspec seems like the better way to go (for now)

@ClemMakesApps good luck ^^ take it easy!

@dimitrieh looks like weight dropdowns is an EE feature 😞 (https://about.gitlab.com/features/)

oh no! what do we do @fatihacet ? :)

moved to gitlab#5840

Hey! 👋

GitLab is moving all development for both GitLab Community Edition and Enterprise Edition into a single codebase. The current gitlab-ce repository will become a read-only mirror, without any proprietary code. All development is moved to the current gitlab-ee repository, which we will rename to just gitlab in the coming weeks. As part of this migration, issues will be moved to the current gitlab-ee project.

If you have any questions about all of this, please ask them in our dedicated FAQ issue.

https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

You can also find more information here:

• https://gitlab.com/gitlab-org/gitlab-ee/issues/13304
• https://about.gitlab.com/2019/08/23/a-single-codebase-for-gitlab-community-and-enterprise-edition/

Frequently Asked Questions

For an up to date list of questions and answers, please take a look at https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

What will we do with the repository names?

https://gitlab.com/gitlab-org/gitlab-ee/ will become https://gitlab.com/gitlab-org/gitlab, and https://gitlab.com/gitlab-org/gitlab-ce will become https://gitlab.com/gitlab-org/gitlab-foss.

Why rename gitlab-ce to gitlab-foss?

Using "gitlab" and "gitlab-ce" would be confusing, so we decided to rename gitlab-ce to gitlab-foss to make the purpose of this FOSS repository more clear

I created a merge requests for CE, and this got closed. What do I need to do?

You will need to create a merge request at https://gitlab.com/gitlab-org/gitlab-ee/. This link will eventually redirect to https://gitlab.com/gitlab-org/gitlab.

How does the licensing work in this new setup?

Everything in the ee/ directory is proprietary. Everything else is free and open source software. If your merge request does not change anything in the ee/ directory, the process of contributing changes is the same as when using the gitlab-ce repository.

Will you accept merge requests on the gitlab-ce/gitlab-foss project after it has been renamed?

No. Merge requests submitted to this project will be closed automatically.

Will I still be able to view old issues and merge requests in gitlab-ce/gitlab-foss?

Yes.

How will this affect users of GitLab CE using Omnibus?

No changes will be necessary, as the packages built remain the same.

How will this affect users of GitLab CE that build from source?

Once the project has been renamed, you will need to change your Git remotes to use this new URL. GitLab will take care of redirecting Git operations so there is no hard deadline, but we recommend doing this as soon as the projects have been renamed.

Where can I see a timeline of the remaining steps?

https://gitlab.com/gitlab-org/gitlab-ee/issues/13304

Will community contributions submitted to the new "gitlab" repository be available in the new gitlab-foss repository?

Yes, these changes will be synced to gitlab-foss automatically, several times per day.

locked this issue