ActiveModel::MissingAttributeError: missing attribute: discussion_id

https://sentry.gitlap.com/gitlab/gitlabcom/issues/10483/

ActiveModel::MissingAttributeError: missing attribute: discussion_id
  app/models/note.rb:268:in `ensure_discussion_id'
    return if self.discussion_id
  lib/gitlab/metrics/instrumentation.rb:155:in `block in ensure_discussion_id'
    trans.method_call_for(#{label.to_sym.inspect}).measure { super }
  lib/gitlab/metrics/method_call.rb:23:in `measure'
    retval = yield
  lib/gitlab/metrics/instrumentation.rb:155:in `ensure_discussion_id'
    trans.method_call_for(#{label.to_sym.inspect}).measure { super }
  app/models/network/graph.rb:31:in `collect_notes'
    .each do |item|
...
(130 additional frame(s) were not displayed)

Reassigned to @DouweM

I think this is fixed via https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5913, but I want to make sure that's the case since this is happening quite a bit.

mentioned in issue #21128 (closed)

It looks like this fails because discussion_id may not always be part of the SELECT statement:

irb(main):019:0> notes[0]
  Note Load (10.3ms)  SELECT notes.commit_id, count(notes.id) as note_count FROM "notes" WHERE "notes"."project_id" = $1 AND (noteable_type = 'Commit') GROUP BY notes.commit_id  [["project_id", 13083]]
ActiveModel::MissingAttributeError: missing attribute: discussion_id

Reassigned to @stanhu

mentioned in commit 415e22a2

mentioned in merge request !5922 (merged)

mentioned in commit 5cb488e8

Status changed to closed by merge request !5922 (merged)

mentioned in commit 707bb9dc

Mentioned in commit 5cb488e8

Mentioned in commit nick.thomas/gitlab-ee@707bb9dc

mentioned in merge request !14785