Wrong Urlencoding when Switching Branch in Graphs / Contributers

Summary
We are using gitflow and are naming our featurebranches like feature/#ISSUENUMBER.
If I want to switch to some of those branches in the Graphs view - i get a HTTP 404 Error.
Gitlab redirects to https://SERVER/GROUP/PROJECT/refs/switch?utf8=✓&destination=graphs&ref=feature%2F%252310 but it should redirect to https://SERVER/GROUP/PROJECT/refs/switch?utf8=✓&destination=graphs&ref=feature%2F%2310 or https://SERVER/GROUP/PROJECT/graphs/feature%2F%2310 which are both working.

Also, like in Issue #20759 (closed), i am unable to switch to those branches in the Commit view.

Reproduce
Just create a Branch like feature/#Number and try to check out the Graphs view.

Expected Results
Correct redirection to the above mentioned URIs.

Server Environments
GitLab 8.11.0
GitLab Shell 3.4.0
GitLab Workhorse 0.7.8
GitLab API v3
Git 2.7.4
Ruby 2.3.1p112
Rails 4.2.7.1
PostgreSQL 9.2.18

/cc @winniehell, is this to do with https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5878?

Added ~480950 regression labels

@smcgivern Thanks for the ping, I'll take a look. I only checked with / not with /# previously.

@smcgivern Do you know by chance why we have the switch page in between? I.e. why don't we redirect to the graphs page directly?

Reassigned to @winniehell

@winniehell no, sorry It looks like it's been there a really long time, though!

@DouweM maybe you know?

@smcgivern I think the problem is not related to !5878 (merged).

When building the dropdown, the branch name is escaped: https://gitlab.com/gitlab-org/gitlab-ce/blob/f4eda673c5d7f98919e74a4542e13ac1bcfdd76d/app/assets/javascripts/project.js#L83

However in the click event $form.serialize() escapes a second time: https://gitlab.com/gitlab-org/gitlab-ce/blob/f4eda673c5d7f98919e74a4542e13ac1bcfdd76d/app/assets/javascripts/project.js#L99

Assignee removed

Reassigned to @winniehell

Fix seems to be as simple as removing the duplicate escape(). I'll make a merge request.

Added ~12980 reproduced on GitLab.com labels

Added frontend and removed ~480950 labels

mentioned in merge request !5956 (closed)

mentioned in issue #21880 (closed)

Mentioned in merge request !6313 (merged)

Status changed to closed by merge request !6313 (merged)

Status changed to closed by commit b9712c81

Mentioned in commit b9712c81

Mentioned in commit 143bd02d

Hey @winniehell, do you know, when the fix/merge request will go live? I am currently running GitLab Community Edition 8.12.6 fa20b51c and the bug still exists.
Thanks for the good work and support !

@schwedenmut it should have been fixed by !6313 (merged) and thus be part of 8.12. But you are right, the issue can still be reproduced on gitlab.com with 8.12.6:

• https://gitlab.com/winniehell/reproduction-area/graphs/master
• switch to feature/#1234

Therefore I am reopening this.

cc @lbennett

Status changed to reopened

Assignee removed

Mentioned in issue #23669 (closed)

Mentioned in issue #23667 (closed)

Added ~423634 label

Reassigned to @lbennett

Milestone changed to %8.13

Started branch 21248-wrong-urlencoding-when-switching-branch-in-graphs-contributers

Mentioned in merge request !7061 (merged)

Milestone changed to %8.14

Status changed to closed by merge request !7061 (merged)

Mentioned in issue #22320 (closed)

Mentioned in commit 4ec7da18

mentioned in merge request !14785