Import of Gitlab export fails with database errors

Added import label

Added ~12980 label

@jameslopez It looks like there is a bug here. I tried to import an export that included protected branch settings on 8.11 and it also failed with the above error. I haven't seen the error related to pipelines though.

Issue confirmed when I tried importing an export which had a protected master branch. When I unprotected master and regenerated the export, importing failed with:

Failed to replace milestones because one or more of the new records could not be saved.

When I destroyed all (2) milestones and regenerated the export, it imported successfully.

Using 8.11.0 346e677e.

+1 same problem here. I cannot afford to delete milestones on the project I wish to duplicate. So no workaround for me (except full fledge clone and re-constructing issues, milestones, merge-requests, etc. by hand).

Thanks for all the info - I'll look into this soon.

Reassigned to @jameslopez

mentioned in merge request !6099 (merged)

@Beep6581 @fboutin do you have a clear path on how to reproduce the problem with milestones? While I can reproduce the protected branches issue, I was unable to get any error importing milestones...

I tried:

Unassigned milestones
Milestones assigned to a MR
Milestones assigned to an issue
Combinations of the above

In my failing project, all the milestones are Closed. They are all assigned with at least one Merge Request and sometimes with an Issue. I didn't set custom Labels, I only used the default set suggested. I have a pipeline defined. No Wiki. No Registry. No Snippets. A couple of Open and Closed Issues.

In Merge Requests and Issues I often see references between each others ("!" and "#") in descriptions, comments and Commits.

@fboutin many thanks! Do you know the GitLab instance version of the export and the import? Were they both the same?

The same. I did Export and Import back-to-back.

@fboutin I tried to replicate your setup and also used both source and omnibus installations with no luck. It would be great if you can send me the exported JSON file project.json (if you decompress the .tar.gz archive) to my email: my first name at gitlab.com? You can obfuscate the IDs/names.

Alternatively, it would be also help if you find a clear path to replicate the issue. I have created milestones with many different options with no luck so far! So it must be something specific / related to your setup somehow...

I definitely get the error Failed to replace protected_branches and I've put a fix for that already, just need to know what's going on with milestones :)

We installed through omnibus. The project was created prior to 8.11.

Oh well, I'm easily able to reproduce the Failed to replace protected_branches issue, but I'm unable to reproduce the Failed to replace milestones because one or more of the new records could not be saved. message.

I tried the very same 3 archives I generated earlier this week. So maybe the problem is not related to the archive itself but with the context.

To make a long story short, I started by creating a new Group where I wish I could replicate/copy a project, not forking it. And one thing I struggled with, even when I tried forking, was that I didn't have the same "visibility level" set between the source group/project and the destination group. That MIGHT give use a clue, I don't know but that's the only thing I have changed between then and now.

I'm sorry I cannot do better so we can pin-point the issue specifically.

@fboutin no worries and thanks a lot! I think I manage to find an issue with milestones and labels shared across multiple issues and merge requests. I'll add add that to the protected branches fix.

mentioned in issue #21799 (closed)

Sorry, can't answer those questions as I removed the milestones and now the project is deleted to.

mentioned in merge request !5273 (merged)

Any idea when this might be merged/released? This is holding me back from being able to use this currently.

Thanks, James

@durandj see https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6099, looks like it should make it into 8.12.

Awesome thanks! Didn't notice that merge request.

Status changed to closed by merge request !6099 (merged)

I got the same problem when exporting/importing project on gitlab "8.12.1 ca3c6a46" => "Failed to replace milestones because one or more of the new records could not be saved."

Here my logs :

Import/Export error raised on /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/import_export/project_tree_restorer.rb:20:in `rescue in restore': Failed to replace milestones because one or more of the new records could not be saved.
["/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/activerecord-4.2.7.1/lib/active_record/associations/collection_association.rb:542:in `replace_records'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/activerecord-4.2.7.1/lib/active_record/associations/collection_association.rb:373:in `block in replace'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/activerecord-4.2.7.1/lib/active_record/associations/collection_association.rb:183:in `block in transaction'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/activerecord-4.2.7.1/lib/active_record/connection_adapters/abstract/database_statements.rb:213:in `block in transaction'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/activerecord-4.2.7.1/lib/active_record/connection_adapters/abstract/transaction.rb:184:in `within_new_transaction'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/activerecord-4.2.7.1/lib/active_record/connection_adapters/abstract/database_statements.rb:213:in `transaction'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/activerecord-4.2.7.1/lib/active_record/transactions.rb:220:in `transaction'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/activerecord-4.2.7.1/lib/active_record/associations/collection_association.rb:182:in `transaction'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/activerecord-4.2.7.1/lib/active_record/associations/collection_association.rb:373:in `replace'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/activerecord-4.2.7.1/lib/active_record/associations/collection_association.rb:47:in `writer'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/activerecord-4.2.7.1/lib/active_record/associations/builder/association.rb:123:in `milestones='", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/activerecord-4.2.7.1/lib/active_record/persistence.rb:240:in `update_attribute'", "/opt/gitlab/embedded/service/gitlab-rails/app/models/project.rb:1278:in `append_or_update_attribute'", "/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/import_export/project_tree_restorer.rb:50:in `block in create_relations'", "/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/import_export/project_tree_restorer.rb:43:in `each'", "/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/import_export/project_tree_restorer.rb:43:in `create_relations'", "/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/import_export/project_tree_restorer.rb:17:in `block in restore'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/activerecord-4.2.7.1/lib/active_record/no_touching.rb:29:in `apply_to'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/activerecord-4.2.7.1/lib/active_record/no_touching.rb:22:in `no_touching'", "/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/import_export/project_tree_restorer.rb:16:in `restore'", "/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/import_export/importer.rb:12:in `each'", "/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/import_export/importer.rb:12:in `all?'", "/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/import_export/importer.rb:12:in `execute'", "/opt/gitlab/embedded/service/gitlab-rails/app/services/projects/import_service.rb:56:in `import_data'", "/opt/gitlab/embedded/service/gitlab-rails/app/services/projects/import_service.rb:19:in `execute'", "/opt/gitlab/embedded/service/gitlab-rails/app/workers/repository_import_worker.rb:19:in `perform'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/processor.rb:152:in `execute_job'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/processor.rb:134:in `block (2 levels) in process'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/middleware/chain.rb:128:in `block in invoke'", "/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/sidekiq_middleware/request_store_middleware.rb:6:in `call'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/middleware/chain.rb:130:in `block in invoke'", "/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/sidekiq_middleware/memory_killer.rb:17:in `call'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/middleware/chain.rb:130:in `block in invoke'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/middleware/server/active_record.rb:6:in `call'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/middleware/chain.rb:130:in `block in invoke'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/middleware/server/retry_jobs.rb:74:in `call'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/middleware/chain.rb:130:in `block in invoke'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/middleware/server/logging.rb:11:in `block in call'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/logging.rb:32:in `with_context'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/middleware/server/logging.rb:7:in `call'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/middleware/chain.rb:130:in `block in invoke'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/middleware/chain.rb:133:in `invoke'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/processor.rb:129:in `block in process'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/processor.rb:168:in `stats'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/processor.rb:128:in `process'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/processor.rb:80:in `process_one'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/processor.rb:68:in `run'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/util.rb:17:in `watchdog'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/util.rb:25:in `block in safe_thread'"]

@jameslopez any workaround ? (without deleting milestone ;))

@achorein looks like something specific... To investigate further, would you be able to send me the project.json file (extracted from the export file) to my email? first name at gitlab.com

Mentioned in issue #22585 (closed)

@achorein thanks! Created the issue https://gitlab.com/gitlab-org/gitlab-ce/issues/22585 - fix should go to either 8.12.2 or 8.12.3 hopefully.

I was having also the pb and from a basic import/export, I obtained this error:

undefined method `[]' for nil:NilClass

(with an empty repo)

@kerautret are you still having the issue after upgrading to 8.12.3 ? I think all those DB errors should be gone.

yes I was just doing the update before testing ;(

@kerautret I did try a few imports in 8.12.3 and all of them seemed to work fine, even on an empty repo. Do you have any steps I can do in order to replicate your problem ? Thanks!

I can send you my exported tar.gz if you want ?

@kerautret thanks! please do - my first name at gitlab.com

just done ;)

@kerautret I imported your project successfully in my 8.12.3 local instance. It just has an empty repo. Can you paste the full stacktrace of the error you are getting?

For the log I have just this: Let me know if I can get a log more precisely (I am just a user of my local gitlab ;)

@kerautret I would suggest you capture what's in production.log while trying to import the project again. If you installed GitLab via omnibus you could do the following in a terminal window, after replicating the issue:

sudo tail -n 1000 /var/log/gitlab/gitlab-rails/production.log > ~/gitlab-export.log

This will copy the last thousand lines to a log file in your home directory called gitlab-export.log

You will have to run the command above immediately after you imported the project and you saw the error you've shown before. You can then look inside the file gitlab-export.log (which should be in your home folder) and find a stacktrace that starts with Import/Export error.... Alternatively you can just remove the > ~/gitlab-export.log bit and try to copy & paste the stacktrace as you see it on the screen...

ok I just done it, thanks for the instructions, here is the result (hoping that it could help you):

Import/Export error raised on /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/import_expor t/project_tree_restorer.rb:20:in rescue in restore': undefined method []' for nil:NilClass ["(eval):3:in title'", "(eval):7:in title='", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/ge ms/activerecord-4.2.7.1/lib/active_record/attribute_assignment.rb:54:in public_send'", "/opt/g itlab/embedded/service/gem/ruby/2.3.0/gems/activerecord-4.2.7.1/lib/active_record/attribute_ass ignment.rb:54:in _assign_attribute'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/active record-4.2.7.1/lib/active_record/attribute_assignment.rb:41:in block in assign_attributes'", " /opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/activerecord-4.2.7.1/lib/active_record/attribu te_assignment.rb:35:in each'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/activerecord- 4.2.7.1/lib/active_record/attribute_assignment.rb:35:in assign_attributes'", "/opt/gitlab/embe dded/service/gem/ruby/2.3.0/gems/attr_encrypted-3.0.3/lib/attr_encrypted/adapters/active_record .rb:28:in perform_attribute_assignment'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/at tr_encrypted-3.0.3/lib/attr_encrypted/adapters/active_record.rb:36:in assign_attributes'", "/o pt/gitlab/embedded/service/gem/ruby/2.3.0/gems/activerecord-4.2.7.1/lib/active_record/core.rb:5 66:in init_attributes'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/activerecord-4.2.7. 1/lib/active_record/core.rb:281:in initialize'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/ gems/default_value_for-3.0.2/lib/default_value_for.rb:142:in initialize'", "/opt/gitlab/embedd ed/service/gem/ruby/2.3.0/gems/actionpack-4.2.7.1/lib/action_dispatch/routing/url_for.rb:104:in initialize'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/activerecord-4.2.7.1/lib/acti ve_record/inheritance.rb:61:in new'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/active record-4.2.7.1/lib/active_record/inheritance.rb:61:in new'", "/opt/gitlab/embedded/service/gem /ruby/2.3.0/gems/activerecord-4.2.7.1/lib/active_record/inheritance.rb:59:in new'", "/opt/gitl ab/embedded/service/gitlab-rails/lib/gitlab/import_export/relation_factory.rb:176:in existing_ or_new_object'", "/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/import_export/relation_f actory.rb:137:in imported_object'", "/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/impo rt_export/relation_factory.rb:102:in generate_imported_object'", "/opt/gitlab/embedded/service /gitlab-rails/lib/gitlab/import_export/relation_factory.rb:42:in create'", "/opt/gitlab/embedd ed/service/gitlab-rails/lib/gitlab/import_export/relation_factory.rb:25:in create'", "/opt/git lab/embedded/service/gitlab-rails/lib/gitlab/import_export/project_tree_restorer.rb:112:in blo ck in create_relation'", "/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/import_export/pr oject_tree_restorer.rb:111:in map'", "/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/imp ort_export/project_tree_restorer.rb:111:in create_relation'", "/opt/gitlab/embedded/service/gi tlab-rails/lib/gitlab/import_export/project_tree_restorer.rb:49:in block in create_relations'" , "/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/import_export/project_tree_restorer.rb: 43:in each'", "/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/import_export/project_tree _restorer.rb:43:in create_relations'", "/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/i mport_export/project_tree_restorer.rb:17:in block in restore'", "/opt/gitlab/embedded/service/ gem/ruby/2.3.0/gems/activerecord-4.2.7.1/lib/active_record/no_touching.rb:29:in apply_to'", "/ opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/activerecord-4.2.7.1/lib/active_record/no_touch ing.rb:22:in no_touching'", "/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/import_expor t/project_tree_restorer.rb:16:in restore'", "/opt/gitlab/embedded/service/gitlab-rails/lib/git lab/import_export/importer.rb:12:in each'", "/opt/gitlab/embedded/service/gitlab-rails/lib/git lab/import_export/importer.rb:12:in all?'", "/opt/gitlab/embedded/service/gitlab-rails/lib/git lab/import_export/importer.rb:12:in execute'", "/opt/gitlab/embedded/service/gitlab-rails/app/ services/projects/import_service.rb:56:in import_data'", "/opt/gitlab/embedded/service/gitlab- rails/app/services/projects/import_service.rb:19:in execute'", "/opt/gitlab/embedded/service/g itlab-rails/app/workers/repository_import_worker.rb:19:in perform'", "/opt/gitlab/embedded/ser vice/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/processor.rb:152:in execute_job'", "/opt/gi tlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/processor.rb:134:in block (2 levels) in process'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/si dekiq/middleware/chain.rb:128:in block in invoke'", "/opt/gitlab/embedded/service/gitlab-rails /lib/gitlab/sidekiq_middleware/request_store_middleware.rb:6:in call'", "/opt/gitlab/embedded/ service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/middleware/chain.rb:130:in block in invo ke'", "/opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/sidekiq_middleware/memory_killer.rb :17:in call'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/mid dleware/chain.rb:130:in block in invoke'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/s idekiq-4.1.4/lib/sidekiq/middleware/server/active_record.rb:6:in call'", "/opt/gitlab/embedded /service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/middleware/chain.rb:130:in block in inv oke'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/middleware/s erver/retry_jobs.rb:74:in call'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4. 1.4/lib/sidekiq/middleware/chain.rb:130:in block in invoke'", "/opt/gitlab/embedded/service/ge m/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/middleware/server/logging.rb:11:in block in call'" , "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/logging.rb:32:in with_context'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/mi ddleware/server/logging.rb:7:in call'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/side kiq-4.1.4/lib/sidekiq/middleware/chain.rb:130:in block in invoke'", "/opt/gitlab/embedded/serv ice/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/middleware/chain.rb:133:in invoke'", "/opt/g itlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/processor.rb:129:in block in process'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/proc essor.rb:168:in stats'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/s idekiq/processor.rb:128:in process'", "/opt/gitlab/embedded/service/gem/ruby/2.3.0/gems/sideki q-4.1.4/lib/sidekiq/processor.rb:80:in process_one'", "/opt/gitlab/embedded/service/gem/ruby/2 .3.0/gems/sidekiq-4.1.4/lib/sidekiq/processor.rb:68:in run'", "/opt/gitlab/embedded/service/ge m/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/util.rb:17:in watchdog'", "/opt/gitlab/embedded/se rvice/gem/ruby/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/util.rb:25:in block in safe_thread'"] Started GET "/root/DevTools/import" for 92.130.229.144 at 2016-09-30 23:42:51 +0200 Processing by Projects::ImportsController#show as HTML Parameters: {"namespace_id"=>"root", "project_id"=>"DevTools"}

@kerautret thanks! While I can't replicate the issue locally I can guess something is going on with a service. Have you ever enabled any issue tracker or do you have any configuration related to them? If not I would suggest removing any issues_tracker configuration in your gitlab.rb configuration file and restarting the application... I can't tell for sure this is the problem but it looks like it's enabled but not configured properly (some configuration values are missing).

The offending service is failed to be imported because of this, it's in the exported project json within the bundled file as GitlabIssueTrackerService

I don't remember using issue_tracker in this project (and no trace of issues_tracker in my gitlab.rb. I can try to export/import other project if you want.

Same problem on my other project. If you want an access to my server let me know ;)

I can confirm I get the exact same error in production.log with the top level error of "undefined method `[]' for nil:NilClass".

thanks @kerautret @JamesMichaelMatthews - I created https://gitlab.com/gitlab-org/gitlab-ce/issues/22891 to investigate that issue further...

Mentioned in issue #24009 (closed)

mentioned in issue gitlab-com/support-forum#1345 (closed)

Import of Gitlab export fails with database errors

Designs

Child items 0

Activity

Admin message

Admin message

Import of Gitlab export fails with database errors

Activity