Removing filter for label containing spaces breaks search

Summary

This bug was found when searching for "feature proposals" associated with another label. Removing the label containing a space doesn't remove it fully from the search. The query parameters still contain the label, but formatted incorrectly.

Steps to reproduce

• Create a new project
• Navigate to Issues > Labels view
• Create the following labels
• feature proposals
• wiki
• Create a new issue associated with both new labels
• Navigate to the Issues index
• Apply a filter for both new labels
• Remove the label containing a space

Expected behavior

Removing the label from the filter should show issues with the remaining filter

Actual behavior

No relevant issues are shown

Relevant logs and/or screenshots

N/A

Output of checks

Results of GitLab application Check

N/A Reproducible on GitLab.com

Results of GitLab environment info

N/A Reproducible on GitLab.com

Additional information

• Project exhibiting the problem (Remove 'feature proposal' label to reproduce the bug)

I was also able to reproduce it locally on master

@markglenfletcher I reverted the last changes made on labels_select.js and it appears to be regression from !6123 (merged)

/cc @iamphill

Edit: @markglenfletcher it looks like if you open the dropdown and then close it (without selecting anything different), the page will remove the feature proposal label. This is another related bug. Not sure if you wanted a separate issue on this one

mentioned in merge request !6237 (closed)

mentioned in merge request !5561 (closed)

Probably related to #21248 (closed) and #20759 (closed). See also my fix there: !5956 (closed)

Hmm @winniehell yeah, looks like there hasn't been a good implementation on escaping single quote characters.

Related? #21920 (closed)

mentioned in issue #21920 (closed)

mentioned in issue #21961 (closed)

Added ~164274 label

Mentioned in merge request !6313 (merged)

Status changed to closed by merge request !6313 (merged)

Status changed to closed by commit b9712c81

Mentioned in commit b9712c81

Mentioned in commit 143bd02d

mentioned in merge request !14785