Change icon for confidential issues

Description

It was decided in #20960 (closed) that the current icon for confidential issues (fa-eye-slash) should be used for the Unsubscribe action, so we need to find a new icon for confidential issues.

Proposal

---

Original Proposal

I propose we use the same icon we do for Private projects (fa-lock). Both uses have a similar meaning and it is a clear symbol.

cc @hazelyang @dzaporozhets

mentioned in issue #20960 (closed)

@cperessini Will there be the ability to lock issues in the future? Would that use the same icon?

@ClemMakesApps I believe that's planned for an upcoming release, so this would indeed conflict with locked issues.

@cperessini how would you suggest we differentiate the two?

@ClemMakesApps @cperessini #18608 (closed)

Added ~19492 ~14281 labels

@ClemMakesApps @connorshea You're right, we can't use that one then. Fontawesome has this icon, fa-low-vision, but I think from the user's perspective it'd be the same as leaving fa-eye-slash in place.

The following options may be too corny, but maybe @hazelyang can do something interesting with them?

We could use a spy like Chrome uses for incognito

A mask, like Firefox

Or a silent/mute icon

Another option could be the fa-shield icon as mentioned in the other thread (not sure if it got missed )

This seems to imply that the issue is protected but I guess may also be potentially confused with it being internal to everyone on gitlab (since that is the designated icon for projects visible only to gitlab.com users)?

Proposed designs:

A

B

C

---

I would select "A" since it also indicates something confidential. What do you think? @cperessini @ClemMakesApps

@ClemMakesApps The shield icon would be consistent with the "internal" or "protected" meaning that it has inside GitLab, but the problem is I don't think that association is very clear if you don't know the meaning beforehand so I wouldn't use it in any more places than we already do.

@hazelyang I originally thought that a key wouldn't work because it's the opposite of a lock, which we already use. But seeing it implemented I think it's a good choice

I do hope we can use B or C somewhere else because I love them!

@hazelyang I like all 3 proposed. I prefer A too because I think confidential issue is closer to something "under lock" rather than "incognito".

@hazelyang I'd pick A too. It's the simplest icon to demonstrate the concept!

Added them to gitlab-design/production/_assets/svg.

Mentioned in issue #22111 (closed)

@cperessini is this still an issue? When looking at this project’s label page it seems like the fa-eye icon is no longer used for subscribing/unsubscribing.

This issue is for changing the eye that is used to indicate confidential issues.

It is still being used currently:

However, maybe this will be taken of with https://gitlab.com/gitlab-org/gitlab-ce/issues/32894

@tauriedavis yes, but the eye icon is no longer used for subscribing/unsubscribing labels, so there's no apparent need to change the confidential issues icon (the reason for this issue). Maybe I'm missing something?

You are right, @pedroms! Sorry, I actually missed that. Thanks for clarifying for me, should have read more closely.

Closing this issue. @hazelyang can look at updating this icon as part of #32894 (closed) .

closed