Anchors to comments in diffs are broken

Visiting this url does not jump you to comment - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/981/diffs#note_1839107

/cc @JobV

What is the expected behaviour? The URL points to the diffs subtab where there are no notes reachable by that id, ie: removing /diffs fixes the issue.

Should we fix the code that generated the wrong URL?

@dzaporozhets is this fixed now?

@sytses no

@flevour the URL points to existing comment:

@dzaporozhets ok, thanks for the clarification. I had actually looked up the note by id and I had only found it under the Discussion tab. Your comment shed some more light on the issue. Basically there are 2 elements with the same id: under Discussion and under Diff. Looking up the element by id will yield only the first occurrence. See

This is annoying. If we can fix this in a patch release, that'd be great. cc @rspeicher

Milestone changed to 8.1

Reassigned to @vsizov

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/1508

@vsizov Looks like your MR was merged, feel free to close this one.

Status changed to closed

Mentioned in commit pfjason/gitlab-ce@3137d155